Testing build #231

[rejetto]

i've been busy with my job lately

download @ www.dovedove.it/hfs/hfs231.exe

what's new
+ default template will warn the user if it is interrupting an upload
- archive was not working with sub-folders of real folders [link]
- possible AV on quit [link]
- AV with some script events [link]

[rejetto]

@those who hack templates
i made a little optimization.
look at function doArchive().
this new way, the list of files is not passed inside the request.
when all files are selected it is useless.

[thexfile]

This may not be build specific.

I noticed after clearing the hit counter the virtual file system loaded a lot faster.
Total, I had about 3,000 built up on my hit counter.

It was taking about 8 seconds for VFS to load before clearing now under a second to load.

"All in all" this build is very stable for me. 

[crazyboris]

hmmm..
my hit counter is over 142000 but i never had that problem.

[rejetto]

it is normal, and not build specific.
it's not exactly related to the number of hits, but to the number of files with hits that are inside real folders. (complex, i know)
so crazyboris may have 10 files with 14200 hits each, and load fast, while you may had 1500 files with 2 hits each.

[sequestrum]

I've got an error report:

Code: [Select]

Access violation at address 005644A4 in module 'hfs.exe'. Read of address 00000060
HFS 2.3 beta (231)
----------------------------------------------------------------
Stack list, generated 2009-04-06 14:34:27
[005644A4]{hfs.exe     } main.TmainFrm.ipPointedInLog (Line 11642, "main.pas" + 3) + $9
[0052DF3F]{hfs.exe     } optionsDlg.ToptionsFrm.FormShow (Line 354, "optionsDlg.pas" + 7) + $A
[0046493D]{hfs.exe     } Forms.TCustomForm.DoShow (Line 2994, "Forms.pas" + 1) + $19
[004695BC]{hfs.exe     } Forms.TCustomForm.CMShowingChanged (Line 5021, "Forms.pas" + 11) + $7
[00404677]{hfs.exe     } System.TObject.Dispatch (Line 9301, "system.pas" + 8) + $0
[0047D64D]{hfs.exe     } Controls.TControl.WndProc (Line 5143, "Controls.pas" + 83) + $8
[00482384]{hfs.exe     } Controls.TWinControl.WndProc (Line 7246, "Controls.pas" + 105) + $6
[0047D1FA]{hfs.exe     } Controls.TControl.Perform (Line 5018, "Controls.pas" + 5) + $F
[004653C5]{hfs.exe     } Forms.TCustomForm.WndProc (Line 3284, "Forms.pas" + 125) + $6
[00481884]{hfs.exe     } Controls.TWinControl.UpdateShowing (Line 6970, "Controls.pas" + 17) + $C
[0047D1FA]{hfs.exe     } Controls.TControl.Perform (Line 5018, "Controls.pas" + 5) + $F
[00481837]{hfs.exe     } Controls.TWinControl.UpdateShowing (Line 6963, "Controls.pas" + 10) + $11
[00481884]{hfs.exe     } Controls.TWinControl.UpdateShowing (Line 6970, "Controls.pas" + 17) + $C
[00481911]{hfs.exe     } Controls.TWinControl.UpdateControlState (Line 6989, "Controls.pas" + 8) + $3
[004847FD]{hfs.exe     } Controls.TWinControl.CMVisibleChanged (Line 8273, "Controls.pas" + 3) + $3
[0047D64D]{hfs.exe     } Controls.TControl.WndProc (Line 5143, "Controls.pas" + 83) + $8
[00482384]{hfs.exe     } Controls.TWinControl.WndProc (Line 7246, "Controls.pas" + 105) + $6
[004653C5]{hfs.exe     } Forms.TCustomForm.WndProc (Line 3284, "Forms.pas" + 125) + $6
[0046B6D5]{hfs.exe     } Forms.TScreen.GetMonitor (Line 6084, "Forms.pas" + 1) + $9
[0047D1FA]{hfs.exe     } Controls.TControl.Perform (Line 5018, "Controls.pas" + 5) + $F
[0047B6F4]{hfs.exe     } Controls.TControl.SetVisible (Line 4168, "Controls.pas" + 5) + $F
[00464CB9]{hfs.exe     } Forms.TCustomForm.SetVisible (Line 3099, "Forms.pas" + 8) + $6
[00469EE0]{hfs.exe     } Forms.TCustomForm.Show (Line 5350, "Forms.pas" + 1) + $5
[0046A144]{hfs.exe     } Forms.TCustomForm.ShowModal (Line 5414, "Forms.pas" + 24) + $3
[0055FC62]{hfs.exe     } main.showOptions (Line 10565, "main.pas" + 2) + $27
[005645C4]{hfs.exe     } main.TmainFrm.Address2name1Click (Line 11653, "main.pas" + 0) + $10
[0045BC31]{hfs.exe     } Menus.TMenuItem.Click (Line 1878, "Menus.pas" + 14) + $C
[0045D44D]{hfs.exe     } Menus.TMenu.DispatchCommand (Line 2603, "Menus.pas" + 5) + $5
[0045E83C]{hfs.exe     } Menus.TPopupList.WndProc (Line 3393, "Menus.pas" + 4) + $12
[0045E779]{hfs.exe     } Menus.TPopupList.MainWndProc (Line 3374, "Menus.pas" + 2) + $8
[0042AC08]{hfs.exe     } Classes.StdWndProc (Line 11572, "classes.pas" + 8) + $0
[00477330]{hfs.exe     } Controls.FindControl (Line 2103, "Controls.pas" + 6) + $C
[0046E836]{hfs.exe     } Forms.TApplication.ProcessMessage (Line 7670, "Forms.pas" + 23) + $4
[0046E87B]{hfs.exe     } Forms.TApplication.HandleMessage (Line 7689, "Forms.pas" + 1) + $6
[0046EB16]{hfs.exe     } Forms.TApplication.Run (Line 7773, "Forms.pas" + 16) + $3
[0056E95E]{hfs.exe     } hfs.hfs (Line 99, "" + 22) + $2
----------------------------------------------------------------
System   : Windows XP Professional, Version: 5.1, Build: A28, "Service Pack 3"
Processor: Intel, Intel(R) Core(TM)2 CPU          6420  @ 2.13GHz, 3200 MHz MMX
Display  : 1920x1200 pixels, 32 bpp
----------------------------------------------------------------
----------------------------------------------------------------
Product Versions

hfs.exe: Build: 0 2009-03-25 19:22:02

Steps to reproduce:
1. Select the last row in the Log section, either by triple clicking or manually marking it
2. Right click and select Address 2 Name...

This only happens when marking the last row. HFS doesn't crash though, I just get that error dialog.
In case it's relevant, the last row reads: 2009-04-06 14:34:14 xxx.xxx.xxx.xxx:63922 Fully downloaded - 2.58 KB @ 0 KB/s - /jobbschema.gif

Please let me know if you need more information.

[crazyboris]

folder with 400+ files inside opens up under 1 sec for me.

[Pit]

@ sequestrum

I dont get this error here if i do your szenerio with the 3rd row and the "adress to name"

[sequestrum]

Well, as I said, it only happens for me when I'm marking the last row.

[Pit]

Yes i marked the third row too and get no error here

[luca69]

The bug is reproducible as described by sequestrum:

Access violation at address 005644A4 in module 'hfs231.exe'. Read of address 0000002D
HFS 2.3 beta (231)

My laptop is running Windows 2000 SP4

But clicking on "close" button, HFS is not crashing but just working fine 

[rejetto]

thanks for reporting.
fixed in next build.