SOLVED (v223):Functional request: folder creation (with upload rights)

[luca69]

It would be nice if a user which has "upload" rights can also create a folder.
Any plan to implement it?
Is it possible to do it with a macro?

[Foggy]

yes it would be possible to do with a macro.

[rejetto]

in the future this function will be totally integrated in HFS.
in the while you can build it via macro. I will write something totally untested, for your inspiration

{.if|{.can upload.}|{:
form to create the folder

{.if|{.postvar|create_folder.}|{:
  {.mkdir|{.postvar|create_folder.}
:}.}

:}.}



...the {.if|{.postvar   may even be omitted, since mkdir should just fail if the name of the folder is empty.

[luca69]

Thanks for the hint. I'll try it when I have some free time 

Bye
Luca
--------------- Edit
I tried to create it next to the "Delete" button with this peace of code:

Code: [Select]

<div style='margin-top:2em;'>
{.if|{.get|can delete.}|
<input type='hidden' name='action' value='delete'>
<input type='checkbox' onclick='var is = document.getElementsByName("selection"); for (var i=0; i < is.length; i++) is[i].checked = this.checked;'> All
<input style='margin-left:1em' type='submit' value='Delete selected' onclick='return confirm("Are you sure?")'>
/if.}
{.if|{.get|can upload.}|
Folder name: <input  type='text' name='fldname' maxlength="25" size="25" >
<input  type='submit' name='createfolder' value='Create Folder' >
{.if|{.postvar|fldname.}|
  {.mkdir|{.postvar|fldname.}.}
/if.}
  /if.}
</div>

The text input field and the button are displayed, but the folder is not created

Any hint?

[rejetto]

1. put it just before </form>, so it will work also when there's no file in the folder
2. it was creating the folder in your HFS folder
3. i think it's better to check for the button instead of the content of the field
4. you forgot to {:quote:} the action. When you don't, the action is always done, not only when the IF is true.

Code: [Select]

  {.if|{.get|can upload.}|
Folder name: <input  type='text' name='fldname' maxlength="25" size="25" >
<input  type='submit' name='createfolder' value='Create Folder' >
{.if|{.postvar|createfolder.}|{:
{.mkdir|%folder-resource%\{.postvar|fldname.}.}
:}/if.}
  /if.}
</form>


[luca69]

Now it works: the folder is created  , but the folder list is not refreshed 
Any hint how can I force the refresh of the page?

[r][m]

I've made several trys at this without success.
I can't get either example posted here to work at all?

Code: [Select]

{.if|{.?action = add.}|{: {.add folder|real|C:\HFS-Folder\Files|Folder1.} :}.}does add a folder to the vfs at root level as a real folder, but it should have been a subfolder.
Search will not find it on my hard drive, so it must actually be virtural.
What I need is to be able to specify directory its created in and folder name.
Any help anyone?

[rejetto]

Now it works: the folder is created  , but the folder list is not refreshed 
Any hint how can I force the refresh of the page?

ah, right, it's because the list is made BEFORE the folder is created.
The easiest solution would be to automatically refresh the page after the creation. But it is ugly.
This is more elegant:

1. replace the code i gave you with this one

Code: [Select]

  {.if|{.get|can upload.}|
Folder name: <input  type='text' name='fldname' maxlength="25" size="25" >
<input  type='submit' name='createfolder' value='Create Folder' >
  /if.}
</form>


2. add this to the template

Code: [Select]

[special:begin]
{.if|{.and| {.get|can upload.} | {.postvar|createfolder.} .}|{:
{.mkdir|%folder-resource%\{.postvar|fldname.}.}
:}/if.}


[luca69]

THANKS !!!!
Now it is perfect! My users will love it 

[rejetto]

does add a folder to the vfs at root level as a real folder, but it should have been a subfolder.

from next build it will be as subfolder.
and more: the name may contain a VFS path, so you can specify where to put it.
"foo" will just go as subfolder of the current folder (or root if not in folder).
while "/foo" will go under the root, "/asd/foo" under asd, and so on.

[luca69]

H E L P !!!

I found a bug: if you create a new folder, you enter into it and you click on the path on the top, than a new folder with the same name is create!!!

How to reproduce it:
1. Enter into a folder where you have upload rights (e.g. "temp") and creates a new folder (e.g. "test")
2. Click on the newly created folder
3. On the top there is the current path: /Home/temp/test: click on "test" a new folder called test is created!!
--> now you can go to /Home/test/test

Each time a new path where you have upload rights is selected, the "test" folder is created!!

The problem is that the "createfolder" is not reset, but I do not know how to do that.

[rejetto]

i tried to reproduce how you said, but it didn't work.
actually, what you saying is strange, because POSTed values should always been discarded by the browser at next request.
did you perhaps remove the method=post of the form

[luca69]

No I did not!
Please find enclosed my template (my_hfs.tlp).
There is also the admin panel and an additional function to enable the user to change the password by himself/herself.

Please Help!

Note: I put on the top the values of createfolder and fldname for debugging; also the java script was a test to clean the vars, but it did not work

hfs.tlp is the clean one only with the create folder code

[r][m]

I too had some bizarre results working with add folder.
The folder created, when browsed should have been empty,
but was the hfs.exe directory! Delete section quit working, also.
Aparrently not build related. Restored with back up copy of my
tpl without add folder section, fixed it. Now to try again 

[luca69]

I did some further tests putting in the top the debug code

Code: [Select]

Vars: createfolder={.postvar|createfolder.}; fldname={.postvar|fldname.};

Even putting back the folder creation to the form ...

Code: [Select]

</div>
{.if|{.get|can upload.}|
Folder name: <input  type='text' name='fldname' maxlength="25" size="25" >
<input  type='submit' name='createfolder' value='Create Folder' >
{.if|{.and| {.get|can upload.} | {.postvar|createfolder.} .}|{:
{.mkdir|%folder-resource%\{.postvar|fldname.}.}
:}/if.}
    /if.}
</form>

I got the same "funny" effect! It looks like the browser "remembers" the last post as the variables are not cleanup (see 3rd screenshot in the attachments)