rejetto forum

dyndns problem

Mars · 12 · 2135

0 Members and 1 Guest are viewing this topic.

Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2039
    • View Profile
As soon as we use the dyndns wizard, it is not possible any more to erase the corresponding field and it even by using the custom, the only solution: mark disable in the menu.

I glimpse another solution: be able to leave space the custom zone to reset without having to get(touch) the file ini.
Quote
procedure forceDynDNSupdate(url:string='');
const
  MSG = 'This option makes pointless the option "Find external address at startup", which has now been disabled for your convenience.';
begin
dyndns.url:=url;
if url='' then exit;

// this function is called when setting any dyndns service.
....

It was, either adopt this solution which has no consequence on the rest of the program, or to add a menu clear above disable ;)
« Last Edit: March 14, 2010, 11:02:30 PM by Mars »


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13309
    • View Profile

Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2039
    • View Profile
missing to reset the dyndns field  :o

Quote
procedure forceDynDNSupdate(url:string='');
const
  MSG = 'This option makes pointless the option "Find external address at startup", which has now been disabled for your convenience.';
begin
dyndns.url:=url;
if url='' then
  begin
  fillchar(dyndns, sizeof(dyndns),0);

  exit;
  end;
// this function is called when setting any dyndns service.

PS: pour silentpliz, attendre l'accord du boss pour la modif de ce post ;)
« Last Edit: March 15, 2010, 12:22:25 AM by Mars »


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13309
    • View Profile
what are the bad effects of not clearing the rest of dyndns?


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2039
    • View Profile
i thinks that it is more short that to have to do

with dyndns do
  begin:='';
  url:='';
  lastResult:='';
  lastIP:='';
  user:='';
  pwd:='';
  host:='';
  active:= false;
  end;

and old information are then cleared

not?


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13309
    • View Profile
you misunderstood me.
i didn't ask why using fillchar instead of assignment.
but what happens (bad) if we do NOTHING about it. :)


about using fillchar, i usually prefer it, but we should first ensure that the memory is deallocated, since strings are allocated dynamically.


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2039
    • View Profile
To leave fields space is a solution to purge wizards but certain information as the password and the username remain stored in the ini during the saving of options

dynamic-dns-updater=
dynamic-dns-user=lolo
dynamic-dns-host=lolo.no-ip.com


detected one bug


+'listen-on='+listenOn+CRLF
+'external-ip-server'+customIPservice+CRLF     //missing one =
+'dynamic-dns-updater='+base64encode(dyndns.url)+CRLF
« Last Edit: March 15, 2010, 03:17:50 PM by Mars »


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13309
    • View Profile
To leave fields space is a solution to purge wizards but certain information as the password and the username remain stored in the ini during the saving of options

don't you think that those information is likely to be useful to the user whenever he will re-use the wizard.
the password is not stored in the ini. the url is. but when you clear the url you clear also the password from the ini.


dynamic-dns-updater=

Quote
+'external-ip-server'+customIPservice+CRLF     //missing one =

thank you


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2039
    • View Profile
Quote
don't you think that those information is likely to be useful to the user whenever he will re-use the wizard.

It would be in this case preferable to add a submenu Clear to purge all infos and not only the url

it is not possible to delete unwanted informations except by editing hfs.ini. ???


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13309
    • View Profile
i don't see privacy or security risks.
how can it harm?


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2039
    • View Profile
It is not a question of risk, but only a logical choice, if we do the housework in a place, so much to take advantage of it to make it everywhere. is'nt it? :D



Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13309
    • View Profile
i see more logical to leave something potentially useful that has no con.