The new template looks awesome, congratulations! And now, after several tests I did on this weekend, the reports...- New jQuery version broke old browser supportI did quite a few tests, and I've found some problems. Since you have updated jQuery from v1.4.2 to v3.3.1, it's probable that you unintentionally have broke support to a wide range of 'not so old' browsers (remember not all Android phones have the latest browser installed), or you could have used some not wide-compatible code syntax too. I've tried several browsers, and the new template only work OK with the latest browser versions, but on most (two years old) browsers, all have the same problem: those new nice buttons doesn't get displayed at all, including the folder path which doesn't get displayed at all (the webfonts are OK). On a desktop browser, the console shows one 'Uncaught SyntaxError: Unexpected identifier' and two 'Unexpected token'. The most easy way to debug this, is to download a somewhat old version of a Chromium-based browser, like this:
SRWare Iron Portable v31 (and
here you can also find other versions if you want to do some more tests). Regardless, this new jQuery change gives also some unexpected results if an user wants to use an old template that depends on jQuery v1.X.X (I'll publish those results too, if you are interested).
- Small functional detailsIf you click on the 'Selection' > 'Mask' button, it will say 'Please enter the file mask to select: *', but there is NO button to accept it. If you are on a desktop browser, you can press the 'Enter' key, but on a mobile device an 'OK' button is needed. This also happens on the 'Move' button, that doesn't have a 'OK'. Another detail: the 'Selection' button is also ONLY displayed, for example, if there is a permission to delete in the current folder, but this is wrong, since if you also have the 'Archive' button visible, you need the 'Selection' button to being able to archive some files (without this, you will archive the whole folder).
- Offline use of 'Font Awesome' iconsSince HFS is often used on private LANs (without external internet connections), it would be best if the 'font-awesome.min.css' (along with the required WebFont files), are included inside the HFS executable (like the jQuery already is). Without that, if you use HFS offline, this new template doesn't work correctly.
- SVG vs WebFonts (or font optimization)If you want to optimize this (since HFS barely uses 10 icons or less), it would be great if you only use the SVG/PNG format, instead of using the complete 'Font Awesome' WebFont. There are at least two sources of ready-to-use 'Font Awesome' icons in SVG/PNG format,
here and
here. You can also check
this very interesting article describing why SVG is better than using icon WebFonts, but that decision is up to you. Another recommendation is to build a
customized 'Font Awesome' version, leaving only the icons used by HFS (to reduce it's size), and you could do that easily on
Fontello.com.
Well, that's all...
Cheers,
Leo.-