Author Topic: Testing build #250  (Read 6979 times)

0 Members and 1 Guest are viewing this topic.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Testing build #250
« on: December 01, 2009, 01:20:21 AM »
the timestamp bug forced me posting this release

download @ www.dovedove.it/hfs/hfs250.exe

what's new
+ new template macro: save cfg, save vfs
- self-test was blocked by ban rules [link]
- timestamps within real folders broken in build #249 [link]

Offline bacter

  • Operator
  • Tireless poster
  • *****
  • Posts: 682
    • View Profile
Re: Testing build #250
« Reply #1 on: December 01, 2009, 01:28:20 AM »
Hi rejetto

Thanks for the save macros !!

The breadcrumbs - from problem isn't solved , but i will use a macro using the breadidx in the html part of the breadcrumbs macro to get it work as expected. ;)
your computer has no brain - use your own !

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1879
    • View Profile
Re: Testing build #250
« Reply #2 on: December 01, 2009, 11:50:33 PM »
It has been quite a while since I had not picked up a bug of this type:

When a name of file in the vfs is preceded or ends by spaces, there is no automatic corrective.   

The following small modification avoids this inconvenience


Code: [Select]
procedure TmainFrm.filesBoxEdited(Sender:TObject; Node:TTreeNode; var S:String);
var
  f: Tfile;
begin
f:=node.data;
[color=blue]s:=trim(s);[/color]  [color=green]//mars 2009[/color]
if f.name = s then exit;
..........

procedure Tmainfrm.setVFS(vfs:string; node:Ttreenode=NIL);
.......
    FK_NAME:
      begin
      f.name:=[color=blue]trim([/color]data[color=blue])[/color]; [color=green]//mars 2009[/color]
      node.text:=[color=blue]trim([/color]data[color=blue])[/color];  [color=green]//mars 2009[/color]
      end;
    FK_FLAGS: move(data[1], f.flags, length(data));
    ......


Otherwise it is possible to meet itself with url as

http://xxx.xxx.xxx.xxx/%20%20%20%20%20%20%20filename.ext%20%20%20%20

instead of it

http://xxx.xxx.xxx.xxx/filename.ext

It is not much but at least it is effective :D

PS: pour silentpliz, tu l'as ton post tant désiré  ;)

Offline jerome

  • Occasional poster
  • *
  • Posts: 36
    • View Profile
Re: Testing build #250
« Reply #3 on: December 03, 2009, 05:24:47 AM »
i don't know why but today avast give me an alert on HFS249 and 250  Win32:Delf-MZG [Trj]
and don't let me download the new version.

The Alwil Software daily joke, a bug reported on many usual applications. (details from a french forum)
http://www.overclocking-pc.fr/forums/showthread.php?t=10414

i submitted hfs250.exe to the false positive report
because for today and until a new database update, all avast users will not be able to open hfs.

« Last Edit: December 03, 2009, 05:52:02 AM by jerome »

Offline MarkV

  • Tireless poster
  • ****
  • Posts: 746
    • View Profile
Re: Testing build #250
« Reply #4 on: December 03, 2009, 06:08:47 AM »
Yes, huge fuck-up in avast! Now a new update is there, manually check for it.
http://worldipv6launch.org - The world is different now.

Offline jerome

  • Occasional poster
  • *
  • Posts: 36
    • View Profile
Re: Testing build #250
« Reply #5 on: December 03, 2009, 06:46:54 AM »
just in time, now it is ok for the test. even the HFS download link is no more reactive.


Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1879
    • View Profile
Re: Testing build #250
« Reply #6 on: December 04, 2009, 01:02:20 AM »
main.pas : Remainders of old versions which are not used

  tplFrmRect: string;
  if h = 'tpl-window' then tplFrmRect:=l;


  customIPservice: string;
  if h = 'external-ip-server' then customIPservice:=l;

customIPservice is used in Utilib.pas but never saved in hfs.ini

Quote
function getExternalAddress(var res:string; provider:Pstring=NIL):boolean;
....
begin
result:=FALSE;
if customIPservice > '' then s:=customIPservice
else
  begin
  loadIPservices();
  if IPservices = NIL then
    loadIPservices(getRes('IPservices'));
  if IPservices = NIL then exit;


Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #250
« Reply #7 on: December 08, 2009, 01:25:44 PM »
procedure TmainFrm.filesBoxEdited(Sender:TObject; Node:TTreeNode; var S:String);

i agree with this, since that's how Windows Explorer behaves (not total commander).
but i won't change the setVFS(), as it has nothing to do with user interaction, it wastes CPU time, and acting on any kind of node may preclude some possibilities.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #250
« Reply #8 on: December 08, 2009, 01:33:50 PM »
customIPservice is used in Utilib.pas but never saved in hfs.ini

i guess it's better to save it as well.
it was introduced in 2004 and i don't rememeber why it was only loaded.

Offline r][m

  • Tireless poster
  • ****
  • Posts: 347
    • View Profile
Re: Testing build #250
« Reply #9 on: December 11, 2009, 04:23:15 PM »
Remove access and remove upload doesn't work in 250. Remove delete still works.
All 3 work in 248.
From Wiki:
As well, if you change your mind, and want to revoke your grant, just set item|videos|remove upload=robert.

Tested the rest of my admin pages, so far no other problems found.
« Last Edit: December 11, 2009, 05:07:22 PM by r][m »

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1879
    • View Profile
Re: Testing build #250
« Reply #10 on: December 31, 2009, 05:36:18 PM »
Quote
A key with the name of "*.txt" already exists
HFS 2.3 beta (250)
----------------------------------------------------------------
Stack list, generated 31/12/2009 18:27:50
[0052F193]{hfs250.exe  } ValEdit.TValueListStrings.KeyIsValid (Line 994, "valedit.pas" + 11) + $22
[0052F698]{hfs250.exe  } ValEdit.TValueListStrings.Put (Line 1109, "valedit.pas" + 2) + $17
[0052D873]{hfs250.exe  } ValEdit.TValueListEditor.SetCell (Line 396, "valedit.pas" + 7) + $10
[0052E470]{hfs250.exe  } ValEdit.TValueListEditor.SetEditText (Line 706, "valedit.pas" + 20) + $F
[00529E23]{hfs250.exe  } Grids.TCustomGrid.UpdateText (Line 3895, "grids.pas" + 2) + $2E
[00529C0C]{hfs250.exe  } Grids.TCustomGrid.HideEdit (Line 3850, "grids.pas" + 3) + $3
[005289BD]{hfs250.exe  } Grids.TCustomGrid.MouseDown (Line 3347, "grids.pas" + 2) + $3
[0052EA8F]{hfs250.exe  } ValEdit.TValueListEditor.DoOnValidate (Line 823, "valedit.pas" + 5) + $15
[0052EF10]{hfs250.exe  } ValEdit.TValueListEditor.MouseDown (Line 929, "valedit.pas" + 7) + $11
[00475B31]{hfs250.exe  } Controls.TControl.DoMouseDown (Line 5249, "Controls.pas" + 7) + $2B
[00475B94]{hfs250.exe  } Controls.TControl.WMLButtonDown (Line 5258, "Controls.pas" + 5) + $E
[00529F9E]{hfs250.exe  } Grids.TCustomGrid.WMLButtonDown (Line 3936, "grids.pas" + 1) + $6
[00475465]{hfs250.exe  } Controls.TControl.WndProc (Line 5143, "Controls.pas" + 83) + $8
[0047A19C]{hfs250.exe  } Controls.TWinControl.WndProc (Line 7246, "Controls.pas" + 105) + $6
[0042102A]{hfs250.exe  } Classes.TThreadList.UnlockList (Line 3359, "classes.pas" + 1) + $7
[0044239C]{hfs250.exe  } Graphics.FreeMemoryContexts (Line 5032, "Graphics.pas" + 12) + $5
[0047985C]{hfs250.exe  } Controls.TWinControl.MainWndProc (Line 7021, "Controls.pas" + 3) + $9
[00479C62]{hfs250.exe  } Controls.TWinControl.IsControlMouseMsg (Line 7124, "Controls.pas" + 9) + $23
[0047A19C]{hfs250.exe  } Controls.TWinControl.WndProc (Line 7246, "Controls.pas" + 105) + $6
[0047985C]{hfs250.exe  } Controls.TWinControl.MainWndProc (Line 7021, "Controls.pas" + 3) + $9
[0042D7AC]{hfs250.exe  } Classes.StdWndProc (Line 11572, "classes.pas" + 8) + $0
[0046F148]{hfs250.exe  } Controls.FindControl (Line 2103, "Controls.pas" + 6) + $C
[0040489C]{hfs250.exe  } System.@CallDynaInst (Line 9179, "system.pas" + 3) + $0
[00497AEA]{hfs250.exe  } Forms.TApplication.ProcessMessage (Line 7670, "Forms.pas" + 23) + $4
[00497B2F]{hfs250.exe  } Forms.TApplication.HandleMessage (Line 7689, "Forms.pas" + 1) + $6
[00493432]{hfs250.exe  } Forms.TCustomForm.ShowModal (Line 5419, "Forms.pas" + 29) + $5
[0056B60A]{hfs250.exe  } main.showOptions (Line 11386, "main.pas" + 2) + $27
[0056CD60]{hfs250.exe  } main.TmainFrm.Accounts1Click (Line 11717, "main.pas" + 0) + $10
[004685E9]{hfs250.exe  } Menus.TMenuItem.Click (Line 1878, "Menus.pas" + 14) + $C
[00469F39]{hfs250.exe  } Menus.TMenu.DispatchCommand (Line 2603, "Menus.pas" + 5) + $5
[0046B328]{hfs250.exe  } Menus.TPopupList.WndProc (Line 3393, "Menus.pas" + 4) + $12
[004E61D2]{hfs250.exe  } ComCtrls.TToolBar.WndProc (Line 19404, "ComCtrls.pas" + 80) + $6
[0042102A]{hfs250.exe  } Classes.TThreadList.UnlockList (Line 3359, "classes.pas" + 1) + $7
[0044239C]{hfs250.exe  } Graphics.FreeMemoryContexts (Line 5032, "Graphics.pas" + 12) + $5
[0046B265]{hfs250.exe  } Menus.TPopupList.MainWndProc (Line 3374, "Menus.pas" + 2) + $8
[0042D7AC]{hfs250.exe  } Classes.StdWndProc (Line 11572, "classes.pas" + 8) + $0
[0046F148]{hfs250.exe  } Controls.FindControl (Line 2103, "Controls.pas" + 6) + $C
[00497AEA]{hfs250.exe  } Forms.TApplication.ProcessMessage (Line 7670, "Forms.pas" + 23) + $4
[00497B2F]{hfs250.exe  } Forms.TApplication.HandleMessage (Line 7689, "Forms.pas" + 1) + $6
[00497DCA]{hfs250.exe  } Forms.TApplication.Run (Line 7773, "Forms.pas" + 16) + $3
[00577DEF]{hfs250.exe  } hfs.hfs (Line 99, "" + 21) + $2
Product Versions

hfs250.exe: Build: 0 31/12/2009 18:26:24

To reproduce this error, go to the options on mimes, create a new line and reproduce an existing key, then change column.

This problem is due to the property keyoptions of the mimebox(component), which contains the keyunique variable as TRUE. ;)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #250
« Reply #11 on: January 13, 2010, 11:37:38 AM »
This problem is due to the property keyoptions of the mimebox(component), which contains the keyunique variable as TRUE. ;)

keyUnique is wanted, because it makes no sense in having twice the same file mask.
anyway, it's annoying this way, and i found no way to actually fix it, so i just came to remove it.
it's not an important check. The user will go by himself.

Offline TCube

  • Tireless poster
  • ****
  • Posts: 445
    • View Profile
Re: Testing build #250
« Reply #12 on: January 13, 2010, 12:16:05 PM »
' lut!

It has been quite a while since I had not picked up a bug of this type

for God sake please spare us your BS  ;D

This is nice :

Quote
customIPservice: string;
  if h = 'external-ip-server' then customIPservice:=l;

customIPservice is used in Utilib.pas but never saved in hfs.ini

Code: [Select]
Citation
function getExternalAddress(var res:string; provider:Pstring=NIL):boolean;
....
begin
result:=FALSE;
if customIPservice > '' then s:=customIPservice
else
  begin
  loadIPservices();
  if IPservices = NIL then
    loadIPservices(getRes('IPservices'));
  if IPservices = NIL then exit;
« Last Edit: January 14, 2010, 06:36:17 AM by TCube »
Make it idiot-proof and I will make a better idiot

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #250
« Reply #13 on: January 18, 2010, 11:43:13 AM »
Remove access and remove upload doesn't work in 250. Remove delete still works.
Tested the rest of my admin pages, so far no other problems found.

thanks for reportin r][m, but trying to reproducing the problem these functions worked fine here.
i created 2 folders, added permissions for access and uploads, then successfully removed them through the {.set item.}
please send me (privately if you prefer support@rejetto.com) what i need to reproduce your problem, like your admin pages, or anything that's easy to set up.

Offline r][m

  • Tireless poster
  • ****
  • Posts: 347
    • View Profile
Re: Testing build #250
« Reply #14 on: January 19, 2010, 05:57:16 PM »
thanks for reportin r][m, but trying to reproducing the problem these functions worked fine here.
Thanks for checking on this.
I've already moved to 251, and when I retested every thing works now.
Maybe I had system problems ? Don't know, but as others have mentioned on the forum
in recent hours, I too have seen some things lately that are inconsistent. (don't work, then do).
If that continues I'll try to make notes on it.