Author Topic: version 2.4  (Read 23467 times)

0 Members and 2 Guests are viewing this topic.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: version 2.4
« Reply #90 on: February 12, 2019, 03:48:32 PM »

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 579
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #91 on: February 13, 2019, 04:58:55 AM »
Anyway, i fear that i'll have to publish 2.4 as it is if we don't find a solution to this translation problem.
Yeah, for me it's OK :) (feel free to release v2.4 as is)

I can't promise anything, but if I have some spare time, I will try to contact the original developer of 'Kryvich's Delphi Localizer' to see if he could give us some 'light' about this issue. In the meantime, feel free to release it as is (when you feel it's the right time to do it). We could leave this translation issue for a future version.
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: version 2.4
« Reply #92 on: February 14, 2019, 12:28:13 PM »
sometimes you get files with long name and no dash/spaces, and it looks bad especially on mobile with little horizontal space, causing horizontal scrolling.
I want to add this css rule for final 2.4
.item-link { word-break: break-word; }

Please give me some feedback
« Last Edit: February 14, 2019, 12:30:19 PM by rejetto »

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 579
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #93 on: February 14, 2019, 09:06:14 PM »
I want to add this css rule for final 2.4
.item-link { word-break: break-word; }
Yes, that looks OK (at least on my side). Don't forget that the original line had "float:left;"

Old line:
Code: [Select]
.item-link { float:left; }
New line:
Code: [Select]
.item-link { word-break: break-all; float:left; }
Also, I've found that "break-all" could work better that "break-word". The W3 specification seem to suggest that "word-break: break-all" is also more compatible with non-english text (like Chinese, Japanese, and Korean), so that would be more unicode compatible, if I'm not mistaken (source). Anyway, that decision is up to you.



Another thing: Don't forget to change 48em to 50em (like you said you would do here, as I originally I've reported here).
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline dj

  • Tireless poster
  • ****
  • Posts: 131
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4 - I want to add this css rule
« Reply #94 on: February 15, 2019, 09:34:26 AM »
alternatively truncate string
.item-link { overflow: hidden; text-overflow: ellipsis }

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 579
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4 - I want to add this css rule
« Reply #95 on: February 15, 2019, 09:16:55 PM »
alternatively truncate string
.item-link { overflow: hidden; text-overflow: ellipsis }
@DJ: That would be nice, but it would also needs adding "white-space: nowrap;". But sadly, your code adds a extra line, one for the file name and another below for the time and file size, even on short file names.

Do some tests, making two kind of long file names (the one without spaces is to recreate non-english languages):

Code: [Select]
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna esse.txt
Code: [Select]
Loremipsumdolorsitametconsecteturadipiscingelitseddoeiusmodtemporincididuntutlaboreetdoloremagnaesseutenimadminimveniamq.txt
Do some tests and see the results, using "white-space: nowrap;" and not using it (and with and without "float: left;").

Code: [Select]
.item-link { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
Code: [Select]
.item-link { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; float: left; }
Adding the "float: left;" we eliminate the "extra line" on short file names, but that makes appear the unwanted horizontal scrolling.

So, what solution do you propose for this, DJ?... ???
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline dj

  • Tireless poster
  • ****
  • Posts: 131
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4 - I want to add this css rule
« Reply #96 on: February 16, 2019, 05:03:23 AM »
@Leo: thanks for testing. It was only a untested idea. I've seen it on my android filemanager.

Code: [Select]
.item-link { float: left; overflow: hidden; text-overflow: ellipsis; max-width: 100%}should do it. Tested on chrome and FF.

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 579
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #97 on: February 16, 2019, 06:32:35 AM »

@dj: Perfect, now it looks good. :) Adding "white-space: nowrap;" is also recommended to support long file names (without spaces):

Code: [Select]
.item-link { float:left; overflow:hidden; text-overflow:ellipsis; white-space:nowrap; max-width:100%; }
(Anyway, Rejetto has the final word if he decides to add this or not, we are just giving out ideas)
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline thexfile

  • Occasional poster
  • *
  • Posts: 12
    • View Profile
Re: version 2.4
« Reply #98 on: February 18, 2019, 02:18:30 AM »
There's no place like home. ;D

Offline dj

  • Tireless poster
  • ****
  • Posts: 131
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4 - a new addon - lazy loading images
« Reply #99 on: March 02, 2019, 12:10:13 PM »
Lazy loading images loads full-img-thumbs at the moment of need (scrolling) to save bandwidth
You can use this, if you have no thumbnails (in images and server). Tested with chrome and FF.

add Well-Controlled Scrolling additionally (chrome and safari).

lazyimages2 prevent load on cellular network (chrome android)

autotheme preselects dark theme at night
« Last Edit: March 10, 2019, 09:32:50 AM by dj »

Offline SilentPliz

  • Operator
  • Tireless poster
  • *****
  • Posts: 1234
  • ....... chut ! shh!
    • View Profile
Re: version 2.4
« Reply #100 on: March 08, 2019, 11:05:35 PM »
Hi boss !  ;)

No sources for these RC ?

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 579
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #101 on: March 16, 2019, 06:18:15 AM »
Hi boss !  ;)

No sources for these RC ?
I also join the petition, but I guess Rejetto is waiting to release the stable version to release the sources. Perhaps he plans to release the final v2.4 stable version soon?... 8)
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: version 2.4
« Reply #102 on: March 17, 2019, 07:20:55 PM »
Also, I've found that "break-all" could work better that "break-word".

i tried both when making the decision. Break-all diminishes readability of file names, with bad and unnecessary breaking.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: version 2.4
« Reply #103 on: March 17, 2019, 07:24:14 PM »
alternatively truncate string
.item-link { overflow: hidden; text-overflow: ellipsis }

didn't test it, but i don't like the idea of truncating the file names. What when you have a difference at the end of them (a common case): you cannot tell the difference anymore.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: version 2.4
« Reply #104 on: March 17, 2019, 07:24:56 PM »
No sources for these RC ?

i published the only file changing, it's a bit of extra work for you, i'm sorry :)