Author Topic: version 2.4  (Read 1609 times)

0 Members and 2 Guests are viewing this topic.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12888
    • View Profile
Re: version 2.4
« Reply #45 on: October 07, 2018, 01:28:36 PM »
- Possible bug found #1: add a real folder, then on root set 'access' and 'delete' to anyone, then try to rename that folder trough the browser, and you will see that the - Possible bug found #2: add a real folder (with several sub-folders inside), give to those inside sub-folders a different comment to each folder. Now rename one of those
- Design issue?: if you give a comment to a folder, that comment gets displayed next to the folder path, without any design or indication that it's a comment.

all of these should be fixed in next release.

Quote
- Here is another different bug report about comments.
this was already fixed, AFAIK

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12888
    • View Profile
Re: version 2.4
« Reply #46 on: October 07, 2018, 02:47:49 PM »

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1842
    • View Profile
Re: version 2.4
« Reply #47 on: October 07, 2018, 05:54:09 PM »
     {.set item|{.force ansi|%folder%{.^fn.}.}|comment={.force ansi|{.postvar|text.}.}.}

not working:   the tag <BR> always appears when editing the comment

however, what I proposed works despite everything

var value = it.find('.comment-text').text() || ''


Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12888
    • View Profile
Re: version 2.4
« Reply #48 on: October 07, 2018, 08:24:28 PM »
not working:   the tag <BR> always appears when editing the comment

strange, i just tested comments with multiple lines, and no problems at all.
Are you sure you are using the default template with no customization.
Do other people have problems?

when comments are saved in descript.ion, each line of comment is ended with code 0x04,0xC,x0D,x0A

yes, you can find a function explicitly adding the bytes, escapeIon()

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1842
    • View Profile
Re: version 2.4
« Reply #49 on: October 07, 2018, 09:38:10 PM »
Are you sure you are using the default template with no customization.
Do other people have problems?


Sorry, i was using the new template of  24b3 as external template new 24b4

yes, you can find a function explicitly adding the bytes, escapeIon()

that's what I understood but too late


EDIT:
@rejetto
do you think you can make a drop-down menu for the "more options" button instead of a central popup, as in the following image?


EDIT: hfs24b4 with internal template
I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item

EDIT:
a really strange thing, with the last exe in two different directories, on one the upload progress works but not the other, I realized that in the one that works I had a default.tpl while in the other I did not have it, I ended up comparing the default.tps of the first with the internal hfs.tpl of the second one, and I realized that réjetto had made a dumpling (fluff, stupidity)

by changing "upload-panel" by "upload panel" he had thus transformed $('#upload-panel') into $('#upload panel') leaving <div id="upload-panel"

EDIT:
@rejetto
do you think you can make a drop-down menu for the "more options" button instead of a central popup, as in the following image?
« Last Edit: October 07, 2018, 11:18:24 PM by Mars »

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 474
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #50 on: October 08, 2018, 12:02:23 AM »
http://www.rejetto.com/hfsfiles/hfs24b4.exe

give it a try
I can't believe it! YOU DID IT!
I had forgotten how amazing you are! :D

Now it works great from Chrome v19.0 to Chrome v31.0 (and beyond).

I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item
Changing:
Code: [Select]
.item-link { float:left; }
To:
Code: [Select]
.item-link { float:none; }
...seems to solve the problem.

by changing "upload-panel" by "upload panel" he had thus transformed $('#upload-panel') into $('#upload panel') leaving <div id="upload-panel"
I did notice that when I was doing a comparison between 'Build 2' vs 'Build 3' with DiffNow, but I didn't say anything because it thought it was a proper fix. By the way, with the last edition, he deleted this line (I don't know is has any effect, because it seems to work OK without that):
Code: [Select]
<link rel="stylesheet" href="/?mode=section&id=icons.css" type="text/css">
do you think you can make a drop-down menu for the "more options" button instead of a central popup?
That could be nice, but (IMHO) only as an option for desktop browsers, because I think on small screen devices, that could lead to usability problems (like clicking by mistake outside the menu and having to start again). Perhaps this can be done using only CSS, but distinguishing between mobile vs desktop by its size is not easy nowadays, since new devices have big screen resolution. As an idea, maybe a new 'mobile' icon can be added (along with the 'lightbulb'), to switch between mobile and desktop, so in the default mobile theme we can have the current modalbox, and in the desktop theme the dropdown proposed by Mars. But that's in the case Rejetto is interested on this.

how to define  comments in Russian characters, store them, and restore them correctly to the web page

this comment как возможная функция
On my PC (using the Build 4), that comment gets stored and displayed as:
Code: [Select]
??? ????????? ???????
...and my browser can display russian characters without problems. Perhaps unicode comments could be stored on Base64 (using `atob()` and `btoa()`). Just an idea...



In the dark theme, the 'foldercomment' needs his own CSS code (new line to add marked in red, and I've used a slightly different color to not to be confused with a file comment):
Quote
body.dark-theme .item .comment { background-color:#444; color:#888; }
body.dark-theme #foldercomment { background-color:#333; color:#999; }

I did a quick test, and it seems all the comment problems I've reported, are solved now (that's great!). :)
« Last Edit: October 08, 2018, 06:36:26 AM by LeoNeeson »
• HFS ahora también disponible en Español! (Clic aqui) :)
• HFS is now also available in Spanish! (Click here)

Offline dj

  • Occasional poster
  • *
  • Posts: 74
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4
« Reply #51 on: October 08, 2018, 03:19:03 AM »
works also with IE11

Quote from: Mars on October 07, 2018, 09:38:10 PM
I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item

Changing:
Code: [Select]
.item-link { float:left; }
To:
Code: [Select]
.item-link { float:none; }...seems to solve the problem.

This alone don't solve the problem just as a non transparent border don't.
The checkboxes must be inserted before the link as already reported (line 952 in the new tpl)

Quote
do you think you can make a drop-down menu for the "more options"
not a drop-down, but always vertical
Code: [Select]
[+common-head]
<style>
.item-menu-dialog {width: initial}
.item-menu-dialog .pure-button {display:block}
</style>
« Last Edit: October 09, 2018, 03:37:04 AM by dj »

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12888
    • View Profile
Re: version 2.4
« Reply #52 on: October 14, 2018, 10:12:33 PM »
do you think you can make a drop-down menu for the "more options" button instead of a central popup, as in the following image?

it would take time and i see no real gain

Quote
I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item

ok, i hope this time is fixed for real

Quote
by changing "upload-panel" by "upload panel" he had thus transformed $('#upload-panel') into $('#upload panel') leaving <div id="upload-panel"

fixed, thanks

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12888
    • View Profile
Re: version 2.4
« Reply #53 on: October 14, 2018, 10:23:50 PM »
Perhaps unicode comments could be stored on Base64 (using `atob()` and `btoa()`).

that would break the descript.ion standard format, i guess

Quote
In the dark theme, the 'foldercomment' needs his own CSS code (new line to add marked in red, and I've used a slightly different color to not to be confused with a file comment):

thanks i'll use that

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12888
    • View Profile
Re: version 2.4
« Reply #54 on: October 14, 2018, 10:26:27 PM »
i'm also going for the vertical item-menu suggestion

www.rejetto.com/hfsfiles/hfs24b5.exe

did you guys try the new forum template? it supports also dual dark/light mode, cool

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1842
    • View Profile
Re: version 2.4
« Reply #55 on: October 14, 2018, 10:35:28 PM »
another bug with comment ?? 

when creating or modifying a comment, the multilines are sent with LF and not with CRLF, therefore the comments of the items of the vfs, as well as those recorded in the ".comment" files are saved in the wrong format and do not appear more correctly in a new edition

the solution found is the following:

Quote
procedure Tfile.setDynamicComment(cmt:string);
var
  s, path, name: string;
  i: integer;
begin
if countSubstr(#13#10,cmt) = 0 then
  cmt:=xtpl(cmt,[#10,#13#10]);

if not isTemp() then
  begin
  comment:=cmt; // quite easy
  exit;
  end;

....
the bug is also effective in version of hfs24b5.exe

another unimportant detail
Quote
    function getAccountRedirect():string;
.....
    // if it's not a complete url, it may require some fixing
    // mod mars 10-2018

    result:=xtpl(result,['\','/']); // if result ansiStart with '\' not necessary to add '/' with  next line of code
    if not ansiStartsStr('/', result) then result:='/'+result;
    end; // getAccountRedirect
« Last Edit: October 14, 2018, 10:49:45 PM by Mars »