Author Topic: Testing build #142  (Read 15082 times)

0 Members and 1 Guest are viewing this topic.

Offline Foggy

  • Tireless poster
  • ****
  • Posts: 806
    • View Profile
Re: Testing build #142
« Reply #15 on: November 11, 2007, 11:18:51 AM »
What do you mean "up" link?

Offline Giant Eagle

  • Tireless poster
  • ****
  • Posts: 535
  • >=3 RAWR!
    • View Profile
    • RAWR-Designs.com
Re: Testing build #142
« Reply #16 on: November 11, 2007, 11:21:03 AM »
There is nothing to 'up' to if you search in the root of the server, cause you are still in the root but you filter everything out.

Offline Comrade Elisey

  • Occasional poster
  • *
  • Posts: 89
  • Cthulhu fhtagn! Cthulhu fhtagn!!!
    • View Profile
    • Dubophone
Re: Testing build #142
« Reply #17 on: November 11, 2007, 03:18:51 PM »
-can i have one little cup of coffee pls?... :)
-why? ???
-just for coding, man!  :P

Offline KalleB

  • Occasional poster
  • *
  • Posts: 97
    • View Profile
Re: Testing build #142
« Reply #18 on: November 11, 2007, 03:24:48 PM »
Nice to see the search function finally :D

There seems to be some problems with it anyway:
Searching in root directory for *.avi or heroes for example lists almost all my files and folders. Searching for * returns even more items, pretty much all I think.

Searching in a subfolder works fine if I edit the template and change the form action='/' into action=''. Then I get correct results for the *.avi search for example...but not in root directory.


PS: How about moving the ".: Menu :." to the upper right corner...where the login used to be?
« Last Edit: November 11, 2007, 03:27:26 PM by KalleB »

Offline Giant Eagle

  • Tireless poster
  • ****
  • Posts: 535
  • >=3 RAWR!
    • View Profile
    • RAWR-Designs.com
Re: Testing build #142
« Reply #19 on: November 11, 2007, 05:00:18 PM »
Nice to see the search function finally :D

There seems to be some problems with it anyway:
Searching in root directory for *.avi or heroes for example lists almost all my files and folders. Searching for * returns even more items, pretty much all I think.

Try searching for 'heroes*.avi'

Offline KalleB

  • Occasional poster
  • *
  • Posts: 97
    • View Profile
Re: Testing build #142
« Reply #20 on: November 11, 2007, 05:11:03 PM »
Quote
Try searching for 'heroes*.avi'

No change what so ever... I get 3459 files - total: 10,73 GB.
With *.avi I get 3487 files - total: 23,30 GB
With heroes: 3465 files - total: 10,73 GB
With DSC01305.JPG: 3452 files - total: 8,34 GB
With asdasdasdd: 3452 files - total: 8,34 GB
With "buggy search": 3452 files - total: 8,34 GB

...so there's really no logic :D

On my other 2 PCs with b142 the search works perfectly in the root though... Same build, same template, same OS, pretty much the same software, same browser.
« Last Edit: November 11, 2007, 05:19:46 PM by KalleB »

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #142
« Reply #21 on: November 11, 2007, 06:36:19 PM »
Hello, please go to Menu, Virtual File System and look that you have enabled Recursive Listing!
Greetings from Germany

That's exactly it and that's why black coffee came in handy  ;D

hmm, i didn't think of it.
i guess that if recursive listing is disabled, search should be disabled too.
maybe with a warning when the user disables recursive listing.
is it ok?

Offline MarkV

  • Tireless poster
  • ****
  • Posts: 746
    • View Profile
Re: Testing build #142
« Reply #22 on: November 11, 2007, 06:44:44 PM »
Hello, please go to Menu, Virtual File System and look that you have enabled Recursive Listing!
Greetings from Germany

That's exactly it and that's why black coffee came in handy  ;D

hmm, i didn't think of it.
i guess that if recursive listing is disabled, search should be disabled too.
maybe with a warning when the user disables recursive listing.
is it ok?

Yeah I think so. :)
http://worldipv6launch.org - The world is different now.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #142
« Reply #23 on: November 11, 2007, 06:45:27 PM »
On my other 2 PCs with b142 the search works perfectly in the root though... Same build, same template, same OS, pretty much the same software, same browser.

you are saying that the same HFS gives different results on localhost and over the network?
your vfs file may eventually be useful to understand your case.

Quote
Searching for * returns even more items, pretty much all I think.

ALL is exacty what * means.

Quote
Searching in a subfolder works fine if I edit the template and change the form action='/' into action=''. Then I get correct results for the *.avi search for example...but not in root directory.

searching in the folder only may come later.

Quote
PS: How about moving the ".: Menu :." to the upper right corner...where the login used to be?

i know you are used to that, but i think it is more visible on the left, and since it will contain almost all "features", it should not be missed.
« Last Edit: November 11, 2007, 06:49:14 PM by rejetto »

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1880
    • View Profile
Re: Testing build #142
« Reply #24 on: November 11, 2007, 10:44:56 PM »
A track for the deletion of files by the users is to force by hfs the suppresion of an uploaded file who has no size?

this will work only if option 'Number files on upload instead of overwriting' is disable

Offline Giant Eagle

  • Tireless poster
  • ****
  • Posts: 535
  • >=3 RAWR!
    • View Profile
    • RAWR-Designs.com
Re: Testing build #142
« Reply #25 on: November 12, 2007, 02:21:42 PM »
hfs #138

what's new
+ new URL parameters: filter, files-filter, folders-filter, page www.rejetto.com/forum/?topic=5073#msg1028672

?page=2&limit=20 doesnt work? It just shows the first 20 files.

Or am i missing a vital part now?

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #142
« Reply #26 on: November 12, 2007, 02:53:25 PM »
'page' fixed in next build
« Last Edit: November 12, 2007, 02:56:28 PM by rejetto »

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1880
    • View Profile
Re: Testing build #142
« Reply #27 on: November 12, 2007, 03:42:57 PM »
Quote

toSkip:=0;
if (conn = NIL) or (conn.data = NIL) then
  data:=NIL
else
  begin
  data:=conn.data;
  toSkip:=StrToIntDef(par('offset'), 0);
  if limit < 0 then

    limit:=StrToIntDef(par('limit'), -1);
  if (toSkip = 0) and (limit > 0) then
    toSkip:=StrToIntDef(par('offset'), 0)*limit;

  end;

'page' can be resolved by this change

Quote
toSkip:=0;
if (conn = NIL) or (conn.data = NIL) then
  data:=NIL
else
  begin
  data:=conn.data;
  limit:=StrToIntDef(par('limit'), -1);
  toSkip:=ifThen(data.params.IndexOf('offset') >= 0,StrToIntDef(par('offset'), 0);StrToIntDef(par('page'), 0)*limit);
end;

OFFSET is priority on PAGE ,
?offset=15&page=3&limit=6 will be result ?offset=15&limit=6
?page=3&limit=6 will be equiv to ?offset=18&limit=6
« Last Edit: November 12, 2007, 03:53:44 PM by mars »

Offline KalleB

  • Occasional poster
  • *
  • Posts: 97
    • View Profile
Re: Testing build #142
« Reply #28 on: November 12, 2007, 07:37:20 PM »
Quote
you are saying that the same HFS gives different results on localhost and over the network?
your vfs file may eventually be useful to understand your case.

No that's not what I ment. Anyway it turns out there's something wrong with my VFS file. I created a new one and the search worked with it. Could it be that there just was too much files & folders in the previous one so the search choked? I'll see if I could send you my VFS that is not working...

Quote
searching in the folder only may come later.
It's already possible when I just remove the "/" from the action=''...at least with Opera.

Quote
i know you are used to that, but i think it is more visible on the left, and since it will contain almost all "features", it should not be missed.
I don't think I'm used to it (I hardly ever use the Login button) but I think the menu shouldn't overlap with these texts:
folder
/Downloads/
 UP
11 folders, 10 files - Total: 2,17 GB


...as it does now. What if you're f.ex. just about to click that "Folder archive" but you'd like to check what size the folder was with a quick glance...you can't because the menu is on top of it :D There's plenty of room for the menu and the search in the right corner..It looks empty now. The menu button also pushes the page contents even lower (being above the "folder" text), which does not look nice.

And also, the ".:" and ":." should not exist...
« Last Edit: November 12, 2007, 07:42:12 PM by KalleB »

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12949
    • View Profile
Re: Testing build #142
« Reply #29 on: November 13, 2007, 02:44:08 AM »
Could it be that there just was too much files & folders in the previous one so the search choked?

well, it is supposed to work anyway. :)

Quote
Quote
searching in the folder only may come later.
It's already possible when I just remove the "/" from the action=''...at least with Opera.

yes, i know it is easy. the point is to decide how to implement the choice at html level.

Quote
...as it does now. What if you're f.ex. just about to click that "Folder archive" but you'd like to check what size the folder was with a quick glance...you can't because the menu is on top of it :D There's plenty of room for the menu and the search in the right corner..It looks empty now. The menu button also pushes the page contents even lower (being above the "folder" text), which does not look nice.

consider the template in attachment

Quote
And also, the ".:" and ":." should not exist...

you don't like them eh?