Author Topic: version 2.4  (Read 16184 times)

0 Members and 1 Guest are viewing this topic.

Offline dj

  • Tireless poster
  • ****
  • Posts: 107
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4 - language
« Reply #105 on: March 18, 2019, 04:23:44 AM »
while testing languages-addon, i found some strings in hfs.tpl not translated:
"Search" (line 105) and "Delete" (line 154) in hfs24rc2
« Last Edit: March 18, 2019, 05:29:44 AM by dj »

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Changes needed in default template for v2.4 RC3
« Reply #106 on: March 18, 2019, 11:46:47 PM »
while testing languages-addon, i found some strings in hfs.tpl not translated:
"Search" (line 105) and "Delete" (line 154) in hfs24rc2
Good find! :) There were TOO many strings (more than 15 changes) that were needed to be modified in the default template. Check the attached 'hfs.tpl' along with the updated spanish translation diff, that I've updated here... ;)

I'm uploading the modified file so Rejetto could use it in a future hfs24rc3.exe (obviously, he could see the changes using an online service like DiffNow or viewing a report of changes, that I've also upload here). I've also changed the "48em to 50em" thing (as it was previously reported here, and accepted by Rejetto here). Any experienced user is welcome to confirm and verify if my modifications are good or not... ;)



» Silly question: does "hfs.diff.tpl" ONLY works on sub-folders? (because currently, if "hfs.diff.tpl" is on root, it doesn't work). Is that the normal behavior? (it doesn't should work on root too?).
 
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #107 on: March 23, 2019, 10:20:03 PM »
@Rejetto: boss, did you had time to review this?...
Are my changes approved for v2.4 RC3?... :)
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1876
    • View Profile
Re: version 2.4
« Reply #108 on: March 24, 2019, 01:53:03 AM »
I am in favor of these, exepted modifications for two things
line 448 -> HFS is the fixed name of the program, do not use {.! HFS.}
line 556 -> Anonymous is an account name, do not translate it with {.! Anonymous.}.}

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #109 on: March 24, 2019, 04:28:16 AM »
@Mars: You are right! :) I agree on both, but mostly on the first (because that introduced a bug!). I've didn't realize that 'Anonymous' (on line 560) is case sensitive, so {.!Anonymous.} needs to be replaced with {.!anonymous.} (thanks to SilentPliz for point me out that 'Anonymous' was case sensitive). ;)

This line needs to be replaced:
Quote
{.add to log|{.if|%user%|{.!User.} %user%|{.!Anonymous.}.} {.!renamed.} "{.^x.}" {.!to.} "{.^yn.}".}

With this correct line (it's only one letter change):
Quote
{.add to log|{.if|%user%|{.!User.} %user%|{.!anonymous.}.} {.!renamed.} "{.^x.}" {.!to.} "{.^yn.}".}

And I've added {.!HFS.} on line 452, because that already was on another place, in line 31, and that could be useful if someone wants to hide or change the name of the server (for security purposes), but since anyone could edit the template, it's not needed after all. But no harm is done if that is left (you can see {.!HFS.} was also included on the default template of v2.3m and even on v2.3k).
« Last Edit: March 24, 2019, 10:02:35 AM by LeoNeeson »
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline dj

  • Tireless poster
  • ****
  • Posts: 107
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4 - bug
« Reply #110 on: March 24, 2019, 08:40:53 AM »
"Switch On" and "Switch Off" button is reversed

update:
either only I have the error or nobody has noticed
Find the mistake between the two pictures! Image shows server turned on
« Last Edit: March 25, 2019, 04:24:34 AM by dj »

Offline SilentPliz

  • Operator
  • Tireless poster
  • *****
  • Posts: 1223
  • ....... chut ! shh!
    • View Profile
Re: version 2.4
« Reply #111 on: March 24, 2019, 09:12:36 AM »
This line needs to be replaced:
With this correct line:
(By the way, talking about macro syntax, I'm curious to know why "%user%|{.!User.}" is working fine without giving an error, but "%user%|{.!Anonymous.}." throws an error, being that both values are on the same place).

Hi !

Try anonymous in place of Anonymous
Case sensitive (?)

Edit :  post deleted by mistake.  Restored here. I'am much better.  :o

« Last Edit: March 24, 2019, 05:54:46 PM by SilentPliz »

Offline SilentPliz

  • Operator
  • Tireless poster
  • *****
  • Posts: 1223
  • ....... chut ! shh!
    • View Profile
Re: version 2.4 - bug
« Reply #112 on: March 24, 2019, 11:38:08 PM »
"Switch On" and "Switch Off" button is reversed

Not verified, I remember (I hope):  :)

Switch ON .... Proposes to turn ON the server, so it's currently OFF.

Switch OFF .... Proposes to turn OFF the server, so it's currently ON.

It's like a switch: turn off when it's on; turn on when it's off.
« Last Edit: March 24, 2019, 11:42:50 PM by SilentPliz »

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1876
    • View Profile
Re: version 2.4
« Reply #113 on: March 25, 2019, 12:33:04 AM »
could not reproduce the bug with Anonymous, 
Quote
[]
{.$common-head.}
   <title>{.!HFS.} %folder%</title>
   {.add to log|{.if|%user%|{.!User.} %user%|{.!Anonymous.}.} {.!renamed.} "{.^x.}" {.!to.} "{.^yn.}".}
    <script type="text/javascript" src="/?mode=jquery"></script>

01:30:21 127.0.0.1:1567 Got 397 bytes
01:30:22 127.0.0.1:1567 Anonymous renamed "" to ""
01:30:22 127.0.0.1:1567 Requested GET /

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4 - several bugs
« Reply #114 on: March 25, 2019, 08:38:23 AM »
"Switch On" and "Switch Off" button is reversed
I can confirm this bug! It was introduced on hfs24b6.exe (hfs24b5.exe had this function working correctly). If you look carefully, the icon shows the correct function, meanwhile the text is wrong. I guess this happened to Rejetto when doing some automatic 'search and replace' on the source code, without looking if every replaced instance was the correct (it's something common, that it could happen to anyone).

could not reproduce the bug with Anonymous, 
This is VERY weird! I'm pulling my hairs trying to reproduce the error, but now the bug is not coming back, neither using {.!Anonymous.} or {.!anonymous.}. There must be something with some specific configuration I had, but now I can't reproduce this error anymore (is crazy!). :o

I've saved a screenshot yesterday (just in case), but anyway the bug was not important, since it only was on the template (on client side), not on the HFS program (not on the server side, because the file gets renamed successfully anyway).

This was the error shown (see screenshot):
Code: [Select]
Error: {.break|result=bad session}
ok

But on the logs everything was normal:
Code: [Select]
19:42:22 127.0.0.1:2737 Requested GET /
19:42:25 127.0.0.1:2739 Requested GET /?mode=jquery
19:42:34 127.0.0.1:2740 anonymous renamed "/folder/SomeFile1.gif" to "SomeFile2.gif"

This error happened with some folder having the 'Hidden' flag, and the 'Upload' setting to 'Anyone'. Anyway, this error can't be reproduced anymore (but yesterday was solved only if {.!anonymous.} in lower case was used).



But I've found another interesting things (two possible small bugs):

CASE 1) If you have an empty 'hfs.ini', that file is IGNORED and the settings are saved directly on the registry (the file 'hfs.ini' is deleted on exit, and the account 'can change password' is created normally). Expected behavior: save all the settings on that empty 'hfs.ini'.

CASE 2) If you have a 'hfs.ini' file with a minimal content (like a simple 'space' character, or containing a word like 'HFS' at start), the file is recognized and used to save the settings there (the registry is not used), and if you already have a 'hfs.tpl' along with the 'hfs.exe' file, HFS is NOT creating the default account 'can change password' (if there is no 'hfs.tpl' file, the account 'can change password' is created normally. Expected behavior: the account 'can change password' should be created and saved on the 'hfs.ini' file on this specific scenario (also the settings should be saved in a file, if an empty 'hfs.ini' file is found).

I hope this could be easily fixed... :-\

Keep in touch if you need more details.
Cheers,
Leo.-
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1876
    • View Profile
Re: version 2.4 - bug
« Reply #115 on: March 25, 2019, 06:20:51 PM »
"Switch On" and "Switch Off" button is reversed

update:
either only I have the error or nobody has noticed
Find the mistake between the two pictures! Image shows server turned on

only texts OFF & ON  are reversed, the icons and the function is correct

reversed, the icons and the function is correct

Code: [Select]
SwitchON1.imageIndex:=if_(srv.active, 11, 4);
SwitchON1.caption:='Switch '+if_(srv.active, 'OFF', 'ON');

and managed from these lines until the rb5, since this there may have been a false manipulation in the sources

I'm arguing that something has been changed to look like this

Code: [Select]
SwitchON1.caption:=if_(srv.active, 'Switch ON', 'Switch OFF');
exactly
  S_OFF = 'Switch OFF';
  S_ON = 'Switch ON';
  SwitchON1.caption:=if_(srv.active, S_ON, S_OFF);

should be
  SwitchON1.caption:=if_(srv.active, S_OFF, S_ON);

in order to facilitate the literal translations and no longer fragmented, but that there was a misleading text

I fiddled the exe to correct the inversion pending the new version

http://dl.free.fr/vAaA050dO



« Last Edit: March 26, 2019, 08:02:42 PM by Mars »

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1876
    • View Profile
Re: version 2.4
« Reply #116 on: March 25, 2019, 07:06:33 PM »
This was the error shown (see screenshot):
Error: {.break|result=bad session}
ok

It is not a real bug, it comes from a syntax error in the model at the level of the section of the alias which appears only under very particular conditions because most of the time the text is considered as a comment

we notice that the message of the error does not represent a complete macro

Quote
[special:alias]
check session=if|{.{.cookie|HFS_SID_.} != {.postvar|token.}.}|{:{.cookie|HFS_SID_|value=|expires=-1.} {.break|result=bad session}:}

lit's not new and the problem is present in the default model since the 2.3f, which use cookie to check session
« Last Edit: March 25, 2019, 07:08:30 PM by Mars »

Offline AlexALSP

  • Occasional poster
  • *
  • Posts: 17
    • View Profile
Re: version 2.4
« Reply #117 on: March 27, 2019, 05:53:43 AM »
Much time has passed. But there is no support for other languages. It's sad.  :'(

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1876
    • View Profile
Re: version 2.4
« Reply #118 on: March 27, 2019, 10:36:51 AM »
as long as a definitive solution is not adopted to manage the languages, only a few will serve as support for the study of the translation.Later a wider choice will be available for those who wish to participate in the translation. 

Offline dj

  • Tireless poster
  • ****
  • Posts: 107
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4 - files with long name
« Reply #119 on: March 29, 2019, 07:35:00 PM »
didn't test it, but i don't like the idea of truncating the file names. What when you have a difference at the end of them (a common case): you cannot tell the difference anymore.

thats right (a additional details button is needed)
alternatively hyphenate words (tested with FF, chrome android and edge in mobil-light_V4.4beta)

update: the additional Details button are the item menu buttons

Code: [Select]
[+common-head]
<style>
.item-link {float: left; overflow: hidden; text-overflow: ellipsis; max-width: 100%}
.item-menu-dialog {word-break: break-all}
</style>
« Last Edit: March 30, 2019, 05:26:42 AM by dj »