Author Topic: version 2.4  (Read 16377 times)

0 Members and 3 Guests are viewing this topic.

Offline Mars

  • Operator
  • Tireless poster
  • *****
  • Posts: 1876
    • View Profile
Re: version 2.4
« Reply #75 on: November 19, 2018, 05:03:27 PM »
I do not know which version it was, but we can work around the problem more simply to perform compatibility tests (as could have suggest rejetto)

add a JQUERY folder to the vfs by configuring it as HIDE

put the two files jquery.min.js jquery2.min.js inside

change the reference in every template
<script type="text/javascript" src="/?mode=jquery"></script>

towards
<script type="text/javascript" src="/jquery/jquery.min.js"></script>    -->  hfs23.tpl
or
<script type="text/javascript" src="/jquery/jquery2.min.js"></script>  -->  hfs24.tpl

so it is not necessary to make a change in the exe

if that's not enough, come back to me  ;)

« Last Edit: November 19, 2018, 05:05:54 PM by Mars »

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #76 on: November 21, 2018, 09:04:16 AM »
if that's not enough, come back to me  ;)
Thank you, I appreciate your reply, but it's much better what you have proposed here: having automatic 'template revision' detection (without needed to modify any template). So, if TR2 is detected, then use old jQuery of v2.3m, and if TR3 is detected, then use new jQuery of v2.4. Even if I currently don't needed this change, programming is fun. 8)

Since now I can compile HFS by myself, I would like to experiment adding whatever idea comes to my mind, no matter how crazy the idea is. That's the fun of having your own fork or modification of something: experiment. That's why I've asked if you can share again (that) file, but if you don't have it (or whatever), don't worry, it's OK :) (I will try to implement it by myself).
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline Fysack

  • Tireless poster
  • ****
  • Posts: 615
  • present picture
    • View Profile
    • Admin
Re: version 2.4
« Reply #77 on: December 15, 2018, 12:36:01 AM »
GOD CAN READ YOUR MIND

Offline Fysack

  • Tireless poster
  • ****
  • Posts: 615
  • present picture
    • View Profile
    • Admin
Re: version 2.4
« Reply #78 on: December 15, 2018, 01:01:47 AM »
GOD CAN READ YOUR MIND

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #79 on: January 06, 2019, 07:21:17 PM »
Hi, just passing by, and I see you are all still busy. HFS has come a long way (I still remember the good old days when it started). No reason to stop it. :)

hi Mark, nice to see you around :)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #80 on: January 20, 2019, 05:04:21 PM »
The main idea is adding "a cookie-based login system", so modern mobile browsers could use a form based login system (and not rely on that old and obsolete login popup that most new browsers are now deprecating).

such thing was actually ongoing years ago, then with the hiatus i've lost track of the progress.
i won't consider it for this version anyway, as it would mean further delaying in the publishing of an official update.

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #81 on: January 20, 2019, 05:20:09 PM »
Could you please generate a new base language file (hfs.lng), because I've generated a new one (using kdlscan.exe and lngupdate.exe), but I can't find any new string to translate (and neither any new modification is found).

it does the same to me. I don't know why it seems to ignore the fact that i've been converting many constants to "resourcestring".
I will investigate it.

Quote
You could solve this, changing 48em to 50em:

ok, it seems a quite safe fix to do, so i'll introduce it without testing it myself

Quote
• Another thing more: "developer notes.txt" needs this line to be added:
Code: [Select]
Kryvich's Delphi Localizer https://sites.google.com/site/kryvich/localizer

it is already there

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #82 on: January 20, 2019, 05:29:59 PM »
it does the same to me. I don't know why it seems to ignore the fact that i've been converting many constants to "resourcestring".
I will investigate it.

apparently i had to use the "build", so it generated a .drc file, and then kdlscan worked correctly.
You'll find all new strings at the end.
Sorry for keeping you waiting.

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #83 on: January 21, 2019, 07:34:42 AM »
@Rejetto: Thanks, I see your changes on [ResourceStrings], but still doesn't seem to work (at least using the latest beta hfs24b6.exe).

Do this simple test:
1) Open with a text editor the 'hfs.lng' file.
2) Do a 'search and replace' of the folowing:
    Search this: "Max simultaneous downloads"
    Change with: "Massimo di download simultanei"
3) Save the changes, and now open HFS to see if it worked...
4) Go to: Menu > Limits and you will see that the text was not translated.

If the text was translated fine (using the latest 'still unreleased' beta build you have), then the next build hfs24b7.exe will make those changes visible. If that string was not translated, then there is something else to fix on the code.

I've noticed that a similar string ("Connections inactivity timeout") is being translated OK, so, perhaps you can use that as reference. Keep in touch if there is something I could do to help you to debug this out. ;)
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #84 on: January 24, 2019, 11:21:40 PM »
i tried with the "Switch ON" and it worked, so it's the exe.
try this http://www.rejetto.com/hfsfiles/hfs24rc1.exe

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #85 on: January 26, 2019, 09:26:00 PM »
i tried with the "Switch ON" and it worked, so it's the exe.
try this http://www.rejetto.com/hfsfiles/hfs24rc1.exe
Well... I appreciate you effort, but for as much as I would like to say it's solved, it isn't solved... :-\ The "Switch ON" works, but that's not the main problem.

The problem comes with menu items that has a variable string, like "%s". That's why I've proposed you to make a test with the menu option 'Max simultaneous downloads: %s ...', since it has the variable "%s" that causes the string go untranslated.

There are also another buttons, like "You are in Expert mode" that also can't be translated. And the problem with that button is similar, since it's a button that changes its caption when it's clicked.

(If this doesn't have an easy fix, don't worry, leave it as is for the time being until you find a solution)
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #86 on: January 27, 2019, 06:54:04 PM »
the problem exists but i didn't find a solution.
The %s is not the problem: "total out" works for example. It must be something else. :-\
The problem is not even the changing, because "switch on" and "switch off" do the same, but work.
I'm sorry, but i'm quite lost.
I'm now leaving for a 3-weeks journey in India and Nepal. I can't say about my availability next days.

Offline dj

  • Tireless poster
  • ****
  • Posts: 107
  • 👣 🐾
    • View Profile
    • PWAs
Re: version 2.4
« Reply #87 on: January 28, 2019, 06:05:23 AM »
Addons tested with version 2.4rc1:

addoncheckedadjustment
check boxesbugfix selection
 
audioplayerlightadd mime types* (* .mp3 audio/mpeg, .ogg audio/ogg)
logoutvar ref=document.querySelector('button[onclick*=user]')
jpgimgthumbs
pictureviewer
archive_as_zipsave or change script
dnd_upload and viewthumbs
comment for standard-templatecomment in utf-8
searchcategoriesearch for images, audios,videos

@rejetto, have a nice trip

jpgimgthumbs_v2 can fallback to full-img-thumbs, _v3 works also with progressive jpegs (update)
« Last Edit: March 03, 2019, 03:29:33 AM by dj »

Offline LeoNeeson

  • Tireless poster
  • ****
  • Posts: 574
  • Solitario...
    • View Profile
    • twitter.com/LeoNeeson
Re: version 2.4
« Reply #88 on: February 05, 2019, 01:05:09 AM »
I'm now leaving for a 3-weeks journey in India and Nepal. I can't say about my availability next days.
@Rejetto: Happy holidays! :)
HFS in Spanish (HFS en Español) / How to compile HFS (Tutorial)
• I'm open to help and share any file you may need (just ask me) ;)

Offline rejetto

  • Administrator
  • Tireless poster
  • *
  • Posts: 12945
    • View Profile
Re: version 2.4
« Reply #89 on: February 11, 2019, 02:12:37 PM »
thanks. I'm in Nepal right now, i'll be back sunday.
Anyway, i fear that i'll have to publish 2.4 as it is if we don't find a solution to this translation problem.
here attached the latest source changes.
i shall find the time to give a look at dj's stuff.