rejetto forum

Software => HFS ~ HTTP File Server => Beta => Topic started by: rejetto on September 20, 2018, 09:34:58 PM

Title: version 2.4
Post by: rejetto on September 20, 2018, 09:34:58 PM
http://www.rejetto.com/hfsfiles/hfs24b1.exe

there's a new default template, mobile friendly and responsive.
i'm almost finished.
Would you start to give it a try?

latest version http://www.rejetto.com/hfsfiles/hfs24b6.exe
Title: Re: version 2.4
Post by: dj on September 21, 2018, 02:43:41 AM
http://localhost/fa/font-awesome.css 404 Not Found


addons tested with version 2.4:

addoncheckedadjustment
audioplayerlight (http://rejetto.com/forum/index.php?topic=11754.msg1063922#msg1063922)(playbutton in footer)
logout (http://rejetto.com/forum/index.php?topic=11754.msg1062970#msg1062970)var ref=document.querySelector('button[onclick*=user]')
jpgimgthumbs
pictureviewercoming tomorrow
archive_as_zip (http://rejetto.com/forum/index.php?topic=11754.msg1063899#msg1063899)todo

themes tested with version 2.4: dark
Code: [Select]
[+common-head]
<style>
#files {background:#555}
</style>
Title: Re: version 2.4
Post by: bmartino1 on September 21, 2018, 04:39:19 PM
Have downloaded and will test here in a bit with Android pixel 2 phone amoung other testing device.
Title: Re: version 2.4
Post by: rejetto on September 21, 2018, 06:27:00 PM
oh shit, you are missing ALL the icons :(
i'll publish another version ASAP
Title: Re: version 2.4
Post by: rejetto on September 21, 2018, 07:29:51 PM
ok guys, i'm sorry for wasting your time, please REdownload the link above.
It should be fine now.
Title: Re: version 2.4
Post by: Mars on September 21, 2018, 10:04:05 PM
tests done in firefox on windows

There is an forgetting in the template, is missing a passage in the following line concerning links, to see image

(https://i27.servimg.com/u/f27/16/40/25/39/temp11.jpg)

by removing this line the default disappears
.item-link { float:left; }


There is a problem with the selection tool, when we check a box, it performs the same action as clicking on the name





Title: Re: version 2.4
Post by: dj on September 23, 2018, 05:24:55 PM
There is a problem with the selection tool, when we check a box, it performs the same action as clicking on the name

change '.item-selectable a' to '.item-selectable' (line 932) might help

update: and optionally remove .item-link { float:left; }
Title: Re: version 2.4
Post by: TEA-Time on September 23, 2018, 05:58:43 PM
If I try to edit a comment, I get the "span" tags with the double quote in between in the edit box like in the attached.
Title: Re: version 2.4
Post by: TEA-Time on September 24, 2018, 04:52:32 AM
I'm not sure if this exists in other templates, but I found an interesting gotcha while messing around with uploading from my phone.  Not that anyone would probably do this under normal operation, but I uploaded a file, deleted it, then reuploaded the same file again to try some other functions, and when I clicked the "Reload page" button after the upload finished, the file was deleted without warning.

If I manually reload the page using the pull-down-to-reload function of the browser instead, it tells me that the form (the delete command, but that might not be obvious to some people) will be resubmitted.  But pressing the "Reload page" button bypasses that warning and.. poof.

So I propose instead of doing an actual reload that resubmits the previous form, the "Reload page" button should just do a regular GET for the folder you're sitting at.

Edit: I just noticed that the corresponding entry in hfs.comments.txt does not get removed when any kind of delete happens.
Title: Re: version 2.4
Post by: TEA-Time on September 24, 2018, 05:32:10 AM
Out of the 8 links in the default "ip-services" list, the 5 below error out, causing HFS to fail to obtain the external IP over half the time.  The first 2 result in a page not found error, whereas the rest appear to have parsing issues due to the pages being redesigned.

Code: [Select]
http://www.melauto.it/public/rejetto/ip.php|
http://rejetto.webfactional.com/hfs/ip.php|
http://www.whatsmyrealip.com/|IP is
http://2ip.ru|d_clip_button">
http://www.mario-online.com/mio_indirizzo_ip.php|<strong>


Even if it fails, it only appears to check every "ip-services-time" (not sure what units that value is in), so I propose it tries each link until it succeeds or runs out of links when there is a failure.
Title: Re: version 2.4
Post by: LeoNeeson on September 24, 2018, 06:46:05 AM
The new template looks awesome, congratulations! :)

And now, after several tests I did on this weekend, the reports...

- New jQuery version broke old browser support
I did quite a few tests, and I've found some problems. Since you have updated jQuery from v1.4.2 to v3.3.1, it's probable that you unintentionally have broke support to a wide range of 'not so old' browsers (remember not all Android phones have the latest browser installed), or you could have used some not wide-compatible code syntax too. I've tried several browsers, and the new template only work OK with the latest browser versions, but on most (two years old) browsers, all have the same problem: those new nice buttons doesn't get displayed at all, including the folder path which doesn't get displayed at all (the webfonts are OK). On a desktop browser, the console shows one 'Uncaught SyntaxError: Unexpected identifier' and two 'Unexpected token'. The most easy way to debug this, is to download a somewhat old version of a Chromium-based browser, like this: SRWare Iron Portable v31 (http://download1.srware.net/old/iron/win/portable/IronPortable_31.zip) (and here (http://download1.srware.net/old/iron/win/portable/) you can also find other versions if you want to do some more tests). Regardless, this new jQuery change gives also some unexpected results if an user wants to use an old template that depends on jQuery v1.X.X (I'll publish those results too, if you are interested).

- Small functional details
If you click on the 'Selection' > 'Mask' button, it will say 'Please enter the file mask to select: *', but there is NO button to accept it. If you are on a desktop browser, you can press the 'Enter' key, but on a mobile device an 'OK' button is needed. This also happens on the 'Move' button, that doesn't have a 'OK'. Another detail: the 'Selection' button is also ONLY displayed, for example, if there is a permission to delete in the current folder, but this is wrong, since if you also have the 'Archive' button visible, you need the 'Selection' button to being able to archive some files (without this, you will archive the whole folder).

- Offline use of 'Font Awesome' icons
Since HFS is often used on private LANs (without external internet connections), it would be best if the 'font-awesome.min.css' (along with the required WebFont files), are included inside the HFS executable (like the jQuery already is). Without that, if you use HFS offline, this new template doesn't work correctly.

- SVG vs WebFonts (or font optimization)
If you want to optimize this (since HFS barely uses 10 icons or less), it would be great if you only use the SVG/PNG format, instead of using the complete 'Font Awesome' WebFont. There are at least two sources of ready-to-use 'Font Awesome' icons in SVG/PNG format, here (https://github.com/ladjs/font-awesome-assets) and here (https://github.com/encharm/Font-Awesome-SVG-PNG). You can also check this (https://css-tricks.com/icon-fonts-vs-svg/) very interesting article describing why SVG is better than using icon WebFonts, but that decision is up to you. Another recommendation is to build a customized (https://github.com/FortAwesome/Font-Awesome/wiki/Customize-Font-Awesome) 'Font Awesome' version, leaving only the icons used by HFS (to reduce it's size), and you could do that easily on Fontello.com (http://fontello.com/).

Well, that's all... :)

Cheers,
Leo.-
Title: Re: version 2.4
Post by: dj on September 25, 2018, 04:20:02 AM
- SVG vs WebFonts (or font optimization)
If you want to optimize this (since HFS barely uses 10 icons or less), it would be great if you only use the SVG/PNG format, instead of using the complete 'Font Awesome' WebFont.

I try to use svg. Incomplete, not IE (must change i tags for IE)
update: v2 should work with IE11 (currently untested)
v3 can resize icons

Quote
New jQuery version broke old browser support
I'm not fit in jquery, but it should support Internet Explorer: 9+ (https://jquery.com/browser-support/)
the some not wide-compatible code syntax is ECMAScript6 (https://caniuse.com/#search=es6)
I also think, IE11 should still be supported
Title: Re: version 2.4
Post by: rejetto on September 30, 2018, 07:48:20 PM
thank you all for your comments, they are very useful!

- New jQuery version broke old browser support
I did quite a few tests, and I've found some problems. Since you have updated jQuery from v1.4.2 to v3.3.1, it's probable that you unintentionally have broke support to a wide range of 'not so old' browsers

the problem is hardly jquery 3. I'm using a recent version of javascript. I'm now experimenting to see if I can do without.
I'm now targeting Chrome 48, from Jan 2016. Quite fair i think.

Quote
Regardless, this new jQuery change gives also some unexpected results if an user wants to use an old template that depends on jQuery v1.X.X (I'll publish those results too, if you are interested).

I opted for version 3 because even 2 is no longer supported/fixed. I will experiment reverting to 2 or even 1.

Quote
on a mobile device an 'OK' button is needed.

you don't have the enter-like button on your mobile keyboard?

Quote
Another detail: the 'Selection' button is also ONLY displayed, for example, if there is a permission to delete in the current folder, but this is wrong, since if you also have the 'Archive' button visible, you need the 'Selection' button to being able to archive some files (without this, you will archive the whole folder).

i'll look into this problem

Quote
- Offline use of 'Font Awesome' icons

it's tiresome, but i guess it's good to support those few who use it in such situation.

Quote
If you want to optimize this (since HFS barely uses 10 icons or less),

I made a list of the current situation, and i'm using 26 icons:
asterisk
ban =deny
bars =menu
check-circle
check-square
clock-o
coffee
download
edit
file-archive-o
folder
globe
home
key
lock
quote-left
refresh
retweet
search
star
times-circle
trash
truck
upload
user
user-circle

Also, I checked the size of the downloaded files in Chrome, and it's 100KB.
I tried 'fontello', and it took me almost an hour but now it's 10KB (woff format only).

Quote
You can also check this (https://css-tricks.com/icon-fonts-vs-svg/) very interesting article describing why SVG is better than using icon WebFonts, but that decision is up to you.

Interesting. Anyway, i tried the svg with Chrome 48 and it's not supported. For the moment the woff seems a good choice.
Title: Re: version 2.4
Post by: rejetto on September 30, 2018, 08:13:30 PM
Out of the 8 links in the default "ip-services" list, the 5 below error out, causing HFS to fail to obtain the external IP over half the time.

just updated the list
Title: Re: version 2.4
Post by: rejetto on September 30, 2018, 08:31:09 PM
If I try to edit a comment, I get the "span" tags with the double quote in between in the edit box like in the attached.

fixed in next release
Title: Re: version 2.4
Post by: rejetto on September 30, 2018, 10:24:43 PM
So I propose instead of doing an actual reload that resubmits the previous form, the "Reload page" button should just do a regular GET for the folder you're sitting at.

Edit: I just noticed that the corresponding entry in hfs.comments.txt does not get removed when any kind of delete happens.

thanks for reporting these problems. Should be fixed in next release.
Title: Re: version 2.4
Post by: rejetto on September 30, 2018, 10:29:55 PM
give a look at this new release
http://www.rejetto.com/hfsfiles/hfs24b2.exe

jquery 3 and selection problem remain to be addressed, for next release.
Title: Re: version 2.4
Post by: rejetto on October 01, 2018, 02:46:02 PM
jquery 1.12 seems to be enough for this template, so i'll try to embed that instead.

I've found that the 'move' functionality was broken in beta2.
You'll find attached the template for the next beta.


Title: Re: version 2.4
Post by: dj on October 02, 2018, 04:21:14 PM
I try to replace the script in the menu panel with css  // leave space for the fixed panel

delete the script
replace #menu-panel { position: fixed;
with      #menu-panel { position: -webkit-sticky; position: sticky; margin-bottom:5px;
Title: Re: version 2.4
Post by: LeoNeeson on October 04, 2018, 07:35:28 AM
replace #menu-panel { position: fixed;
with      #menu-panel { position: -webkit-sticky; position: sticky; margin-bottom:5px;
Thanks for this DJ! I've added that in the template I've attached to this post (with some extra (https://daker.me/2013/07/how-to-make-sticky-elements-using-position-sticky.html) code to have a wide open browser support, as it's recommended here (https://developers.google.com/web/updates/2012/08/Stick-your-landings-position-sticky-lands-in-WebKit) (I've used 0.3em instead of 5px as margin-bottom), as follows:

Code: [Select]
#menu-panel { position: -webkit-sticky; position: -moz-sticky; position: -ms-sticky; position: -o-sticky; position: sticky; margin-bottom:0.3em;
...and now: BIG NEWS! :)

After almost 5 hours of hard work (I'm not exaggerating), I did get rid of almost every incompatible JavaScript expression (ECMAScript 6), with the help of the BabelJS.io (https://babeljs.io/) tool (this tool lets you put in next-gen JavaScript, and get browser-compatible JavaScript out). It was a truly VERY painful job, because I've translated every function, one by one at hand, checking every line very carefully (just to be sure nothing goes wrong). So we now have a very compatible template that works beautifully! :D

I hope you like it (Rejetto: you can EASILY see and review all the changes HERE (https://rejetto.com/forum/index.php?action=dlattach;topic=13060.0;attach=8820) or using this online tool (https://www.diffnow.com/)). Please report if something is not working.

jquery 1.12 seems to be enough for this template, so i'll try to embed that instead.
Remember that the latest stable version of HFS (v2.3m), used jQuery version 1.4.2 and not 1.12.

Another thing: you've used .on( method of jQuery, which was implemented on jQuery v1.7, so, before switching back to jQuery v1.4.2 (http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js) you will either have to modify any function using it, or use this (https://gist.github.com/drublic/3457c27e8681a34b75d9) tiny polyfill (found here (https://github.com/twbs/bootstrap/issues/2018), not tested). Also the .split( method of jQuery may not be found on jQuery v1.4.2 (but I'm not sure about that).
Title: Re: version 2.4
Post by: dj on October 04, 2018, 11:44:19 AM
...and now: BIG NEWS! :)

Quickly tested. Also works with IE11 except for the More Options buttons.

Replace in css display:initial with display:inline-block (line326 in Leos tpl) and it works also with IE11
Title: Re: version 2.4
Post by: rejetto on October 04, 2018, 09:22:33 PM
Quote
After almost 5 hours of hard work (I'm not exaggerating), I did get rid of almost every incompatible JavaScript expression (ECMAScript 6),

why did you do this?  :o
i don't think it should support every browser.
what browser are you trying to support?

Quote
Remember that the latest stable version of HFS (v2.3m), used jQuery version 1.4.2 and not 1.12.

it's ok if we get compatibility with other templates, it's not necessary to use the same jquery version.

Quote
Also the .split( method of jQuery may not be found on jQuery v1.4.2 (but I'm not sure about that).

split is a String method, not jquery
Title: Re: version 2.4
Post by: rejetto on October 04, 2018, 11:17:21 PM
www.rejetto.com/hfsfiles/hfs24b3.exe

check it out!

i quickly tested the templates Live and ToG, for jquery 1.12 compatibility, and they look good.

here is a preview of the sources, mars asked
https://takeafile.com/?f=wawubukeno
Title: Re: version 2.4
Post by: dj on October 05, 2018, 02:48:23 AM
the checkboxes are broken (http://rejetto.com/forum/index.php?topic=13060.msg1064021#msg1064021) again
Title: Re: version 2.4
Post by: LeoNeeson on October 05, 2018, 07:25:29 AM
why did you do this?  :o
i don't think it should support every browser.
what browser are you trying to support?
I use SRWare Iron 31 (Portable edition) (http://download1.srware.net/old/iron/win/portable/IronPortable_31.zip), because it's the fastest browser on Windows XP (other browsers are very slow and take a lot of resources). If you don't care about me, don't do this for me, but think that the same Chromium engine is used by default on many Android's browsers (Android 4.0.3 to 4.4), and not everybody have Android 6 to 8 with the latest browsers.

www.rejetto.com/hfsfiles/hfs24b3.exe

check it out!
I see you didn't used the most important parts of my changed template :'( (after all the time it took me to do it). I really can't understand why you insist on using 'ECMAScript 6'. For as much web developers try to make (aka 'force') people upgrade your browser, there are many situations (like old hardware) where it's impossible to always have the latest browser and operating system. On my case, Windows 7 is too slow for old hardware, and the support for new browsers on Windows XP is every day more limited.
> EDIT: I guess you don't care about users like me, the same as more and more people everyday care less for the others (we have the 'global warm' just because that attitude of 'not caring about his neighbor'). OK, don't worry, I accept you don't want to get rid of 'ECMAScript 6', after all you are the boss (è solo fa male l'atteggiamento). [Sorry, but I had a bad day, and now I come to the forum and find this, completing my bad day]
> EDIT2: @Rejetto: È così che mi ringrazi?! Mi sforzo, ti aiuto a segnalare errori e tu mi ignori in questo modo? Mi rende molto triste, veramente...


Bugs found on HFS v2.4 (using the default original template)

- Possible bug found #1: add a real folder, then on root set 'access' and 'delete' to anyone, then try to rename that folder trough the browser, and you will see that the folder it's now NOT shared anymore (the folder is renamed OK on the server's hard disk, but it's not updated on the HFS VFS).

- Possible bug found #2: add a real folder (with several sub-folders inside), give to those inside sub-folders a different comment to each folder. Now rename one of those folders, and the comment for that folder is gone (what really happens?: when HFS rename that folder, it doesn't update the folder name in the 'descript.ion' file, so the comment doesn't get displayed). The same happens if you rename a file that had a comment.

- Here (http://rejetto.com/forum/index.php?topic=13060.msg1064023#msg1064023) is another different bug report about comments.

- Design issue?: if you give a comment to a folder, that comment gets displayed next to the folder path, without any design or indication that it's a comment. Here (https://i.imgur.com/MQpzJ8g.png) is a screenshot of what I'm talking about.



I'm attaching (https://rejetto.com/forum/index.php?action=dlattach;topic=13060.0;attach=8821) to this post an updated template, adding the changes from your latest template of HFS v2.4 Build 3 (hfs24b3.exe) [you can see here (https://rejetto.com/forum/index.php?action=dlattach;topic=13060.0;attach=8822) the differences from the template of Build 3], just in case you care about it.
 
Title: Re: version 2.4
Post by: Mars on October 05, 2018, 01:24:13 PM
Quote
bug report about comments.
recurring problem since very old versions
the management of the comments is delicate because it involves 3 different types of storage
- "menu > VFS > Load single comment file"
- "menu > VFS > Support DESCRIPT.ION"
- hfs.comments file

the last template still contains an old usage of adding comments instead of using the appropriate macros
{.if| {.length|%user%.} |{: {.append| %folder-resource%\hfs.comments.txt |{.filename|%item-resource%.}=uploaded by %user%
/append.} :}/if.}


the correct formula would be preferably the following because it automatically manages the storage of information:
{.if| {.length|%user%.} |{: {.set  item| %item-name% |comment={.filename|%item-resource%.}=uploaded by %user%
/set.} :}/if.}



Quote
- Possible bug found #1 & #2

that's another concern I've reported to rejetto recently,

several solutions are possible, but in the immediate future the safest solution is not to allow such actions on a VFS element

remotely modify the vfs may conflict with the option "Save options >> Autosave Options"






Title: Re: version 2.4
Post by: rejetto on October 05, 2018, 08:18:18 PM
the checkboxes are broken (http://rejetto.com/forum/index.php?topic=13060.msg1064021#msg1064021) again

i never met the problem before now. I studied it and have found the problem: it's the transparent border in the <a>.
I will remove it.
Title: Re: version 2.4
Post by: LeoNeeson on October 06, 2018, 03:56:47 AM
@Mars/Anyone: Do you know why if you use the new template on the old HFS v2.3m, it doesn't work properly? (even using a modern browser). I don't see the reason why it could fail, since all the required files are self-contained on the template.

It gives the following error in the browser's console:

Quote
TypeError: newQ(...).on is not a function.
Quote
TypeError: $('body').on is not a function. (In '$('body').on', '$('body').on' is undefined)

(http://rejetto.com/forum/Themes/default/images/post/question.gif) I'm curious to know why it fails...
Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 10:20:31 AM
but think that the same Chromium engine is used by default on many Android's browsers (Android 4.0.3 to 4.4), and not everybody have Android 6 to 8 with the latest browsers.

so you suggest to support android 4 system browser.
Anyway, we don't have to have all the features working on old browsers. Browsing and downloading would be a basic set. Browsing means also login. I guess that a very old hardware won't be the "main" system, and just need to access to files remotely. What you think?
Does your template work well with that browser (Chrome 31) ?

Quote
I see you didn't used the most important parts of my changed template :'(

i'm still considering.

Quote
I really can't understand why you insist on using 'ECMAScript 6'.

because older javascript is a boring Language. Even when i was using it i had made a function myself trying to emulate the => arrow functions.

Quote
> EDIT: I guess you don't care about users like me, the same as more and more people everyday care less for the others (we have the 'global warm' just because that attitude of 'not caring about his neighbor').

don't rush, my dear  :) Opinions are mostly made by experience. Everybody's experience is limited and doesn't always produce the best of results. I don't see any XP in my life, these days, so you can understand my starting point. I'm just not doing something before understanding why, still discussing, exchanging views and information.

Quote
OK, don't worry, I accept you don't want to get rid of 'ECMAScript 6', after all you are the boss (è solo fa male l'atteggiamento). [Sorry, but I had a bad day, and now I come to the forum and find this, completing my bad day]
> EDIT2: @Rejetto: È così che mi ringrazi?! Mi sforzo, ti aiuto a segnalare errori e tu mi ignori in questo modo? Mi rende molto triste, veramente...

look, i'm sorry you are feeling this way.  :( I think it's the result of coming to conclusions too fast. I didn't decide about this thing, but that's exactly why i didn't include your work yet. I'm discussing it, to understand and try to make a decision.
I thank you for your hard work, i undertand it was very long, but the decision should not be made on the number of hours. Do you agree with this?
Title: Re: version 2.4
Post by: Mars on October 06, 2018, 10:24:31 AM
in all likelihood, this would come from an incompatibility of versions of javascript used as a resource by hfs: 1.4.2 in v2.3m, 1.12.x in v2.4
Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 11:51:03 AM
@Mars/Anyone: Do you know why if you use the new template on the old HFS v2.3m, it doesn't work properly? (even using a modern browser). I don't see the reason why it could fail, since all the required files are self-contained on the template.

i think it's because 2.4 fixed some bugs related to the template loading.
Title: Re: version 2.4
Post by: Mars on October 06, 2018, 01:36:27 PM
why not consider having both versions of jquery.min.js in the exe as resources and somehow make a detection of the new template related to hfs 2.4 and utlser the most appropriate jquery to keep a compatibility


  if data.urlvars.values['mode'] = 'jquery' then
    begin
    if tplversion<'T4' then replyWithString(getRes('jquery'))
         else replyWithString(getRes('jquery2'));
    conn.reply.contentType:='text/javascript';
    exit;
    end;

it would be possible to add a specific instruction in the new templates in order to allow the differentiation of jquery to use
Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 01:43:21 PM
Quote
- Possible bug found #1:
- Possible bug found #2:

thanks for reporting. These bug are of the template itself. I will work on them asap.

Quote
- Design issue?: if you give a comment to a folder,

i had actually not worked on this part yet. Now fixed.

What kind of use you make of your XP computer? Is it a media server? a secondary  computer? a primary computer?
Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 01:45:43 PM
why not consider having both versions of jquery.min.js in the exe as resources and somehow make a detection of the new template related to hfs 2.4 and utlser the most appropriate jquery to keep a compatibility

to get what? maybe you didn't read my previous  post. I tested some old templates and they were compatible with newer jquery.
Let me know if you find some template that is not compatible.
Title: Re: version 2.4
Post by: Mars on October 06, 2018, 01:56:23 PM
I do not know what to answer, for now with hfs 2.4 and the template of 2.3, i can not check some files but COMMENT button does not work

maybe,  am I in special conditions?

I confirm, the good functioning depends on the version jquery in resource

 I updated data.rc  as it

Quote
1 24 "WindowsXP.manifest"
defaultTpl TEXT default.tpl
copyright TEXT copyright.txt
dmBrowserTpl TEXT dmBrowser.tpl
invertban TEXT invertban.txt
filelistTpl TEXT filelist.tpl
uploadDisabled TEXT upload_disabled.txt
uploadHowTo TEXT upload_how.txt
alias TEXT alias.txt
shell GIF shell.gif
IPservices TEXT ipservices.txt
jquery TEXT jquery.min.js
jquery2 TEXT jquery2.min.js

added in main.pas

Quote
  if data.urlvars.values['mode'] = 'jquery2' then
    begin
    replyWithString(getRes('jquery2'));
    conn.reply.contentType:='text/javascript';
    exit;
    end;

in the new template

Quote
[]
{.$common-head.}
   <title>{.!HFS.} %folder%</title>
    <script type="text/javascript" src="/?mode=jquery2"></script>
   <style class='trash-me'>
   .onlyscript, button[onclick] { display:none; }
   </style>

I put in the directory of exe two tpls named hfs23.tpl and hfs24.tpl corresponding to the versions to be tested, which allows from the menu to quickly change used template and refreh the web page

working perfectly, and the compatibility with the old templates remains whole ;D

 use this link to load a demo version  (https://takeafile.com/?f=kayeyosuni)






Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 03:44:27 PM
I do not know what to answer, for now with hfs 2.4 and the template of 2.3, i can not check some files but COMMENT button does not work
maybe,  am I in special conditions?
I confirm, the good functioning depends on the version jquery in resource

good finding, thanks.
Compatibility with template "TR2" is important, as a lot of people have a "customized template" and would have problems updating to HFS 2.4 .
I think i have a better solution than keeping 2 different libraries: I'm appending to jquery file the "jquery-migrate-1.4.1.min.js" that will give compatibility with just 10KB (4 when gzipped). I just tested it for the "comment" feature, and it fixed it.
Title: Re: version 2.4
Post by: Mars on October 06, 2018, 03:50:13 PM
with just 10KB (4 when gzipped)

women often say that it is not the size that is the most important, but the quality of the "work" and the pleasure it gives  ;D

can you load the demo version that I put and test the addition of userCFG and see result in hfs.ini  ;)

user data can be defined with SET INI and GET INI for use in a template, and managed from the options dialog (F7 last tab)

these data can be used as persistent variables between two hfs launches
Title: Re: version 2.4
Post by: dj on October 06, 2018, 04:16:13 PM
you are discussing about different versions of jquery.

jQuery was born many years ago when browser implementations were very different, and much of the advanced functionality (like querySelectorAll) was not implemented. Now with the new javascript, there's very little reason for jQuery.

why not use the change and write the template without jquery?
For the old templates you can leave jquery in hfs or change one line in the old template.

If I have (5 hours) time, I will try to rewrite the template without jquery.
Title: Re: version 2.4
Post by: Mars on October 06, 2018, 04:29:50 PM
@rejetto

discovery new bug with comment  hfs 2.3 and 2.4 are same

comments in hfs.comment.txt or descript.ion  seem saved trough "htmlEconde" function

    case s of
      '&': p:='&amp;';
      '<': p:='&lt;';
      '>': p:='&gt;';
      '"': p:='&quot;';
      '''': p:='&#039;';
      else p:=s;
      end;

test.txt=there is a &quot;bug&quot;\nwith comments\ntext is saved as\nhtml code \nas with &quot;htmlencode&quot; function



when used multilines in comments, lines are serapated wit '\n'  (that is correct), but when editing
comment with web page \n are converted as <br> and appear on screen

when comments are saved in descript.ion, each line of comment is ended with code 0x04,0xC,x0D,x0A

Quote
Here, I mean that the descript.ion file contains a backslash and a letter 'n' where I typed a line break, and two special characters 04 C2 at the end of the comment. In addition, the line is ended by a Windows line break 0D 0A.

Apparently, the two extra characters at the end of the line signal the end of a multiline comment. If I remove them, the comment is rendered as a single line in the GUI, and the '\n' sequences are displayed literally.
Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 05:32:25 PM
with just 10KB (4 when gzipped)
women often say that it is not the size that is the most important, but the quality of the "work" and the pleasure it gives  ;D

that you mention is not the gain, but the price to pay. The gain is that we have 1 library ;)

Quote
user data can be defined with SET INI and GET INI for use in a template, and managed from the options dialog (F7 last tab)

Sorry mars but i will consider that feature later.
At the moment my priorities are the new template and bugs.
I'm struggling to find the time to make this new version.
Title: Re: version 2.4
Post by: rejetto on October 06, 2018, 05:40:23 PM
why not use the change and write the template without jquery?

Well, we are targeting some old browser too.
By the way, i've decided to restrict to ES5. (LEO read here, this concerns you)
I've also just noticed that these resources (jquery included) are not correctly cached. I'll have to fix this too. :(
Title: Re: version 2.4
Post by: LeoNeeson on October 06, 2018, 05:53:49 PM
First of all, sorry for my misplaced comment :-[ (I felt bad yesterday, and I thought you will never notice my hidden comment). I'm glad to see that you are open minded and that you appreciate my time, and there is no hurry (take your time to make the decision). My initial worries were that you could have been using 'ECMAScript 6' on purpose, as part of the massive 'browser planned obsolescence (https://www.google.com/search?q=browser+planned+obsolescence&sa=N)' there is currently going on (but now after reading your comments I notice that I was wrong, so, sorry again for my comment). Feel free to take whatever decision you think is best. :)

What kind of use you make of your XP computer? Is it a media server? a secondary  computer? a primary computer?
One of them I used them a media server on WinXP (for local sharing files, offline), but I also have one WinXP online (with a firewall) as one of my primary computers (that PC is used as client of the offline PC), and then I have another much faster PC only for gaming and specific applications, loaded with Win7 (but it's mostly turned off, because it's too noisy to have it on 24/7, and mostly offline).

Does your template work well with that browser (Chrome 31) ?
It does! :D it works perfect not only with Chrome 31 but even with Chrome 19! (as well it works fine with Firefox 24, Firefox 31, K-Meleon Web Browser 75, and others I've tested). Of course it doesn't work with Firefox 3.x or IE6, but nobody use them nowadays.

don't rush, my dear  :) Opinions are mostly made by experience. Everybody's experience is limited and doesn't always produce the best of results. [...] I think it's the result of coming to conclusions too fast.
I agree, and it's something I work every day on being better. I'm somewhat "passional", in the meaning of sometimes I take decisions 'being carried away by feelings or thoughts, without rationally thinking about the consequences' (I took definition from the dictionary).

because older javascript is a boring Language. Even when i was using it i had made a function myself trying to emulate the => arrow functions.
That explains all! :) and it was my mistake thinking it was on purpose (part of the 'planned obsolescence (https://en.wikipedia.org/wiki/Planned_obsolescence)' that is currently happening on many things). Sorry for my mistake.

I thank you for your hard work, i undertand it was very long, but the decision should not be made on the number of hours. Do you agree with this?
Absolutely! Feel free to take whatever decision you think is best. :)

I have a possible solution to all this: perhaps this could be fixed doing a small routine, that detects if the browser doesn't support "the => arrow functions" (or other 'ECMAScript 6' expressions), and then it 'dynamically translates' those functions/expressions with older JavaScript code. Doing this, you only do that routine once, and you don't have to change every function. What do you think?... :)
Title: Re: version 2.4
Post by: Mars on October 06, 2018, 07:21:22 PM
Quote
when used multilines in comments, lines are serapated wit '\n'  (that is correct), but when editing
comment with web page \n are converted as <br> and appear on screen

same bug  in previous versions,  the offender is discovered, it is necessary to correct the setcomment function of the template

        function setComment() {
            var value = it.find('.comment-text').html() || ''    // change .html() by .text()
            ask(this.innerHTML, {type:'textarea', value}, s=>
                s===value || ajax('comment', { text:s, files:name }))
        }//setComment

Quote
test.txt=there is a &quot;bug&quot;\nwith comments\ntext is saved as\nhtml code \nas with &quot;htmlencode&quot; function
failing to do better: , this patch provides a temporary solution

procedure Tfile.setDynamicComment(cmt:string);
var
  s, path, name: string;
  i: integer;
begin
//as a possible function htmlDecode(s:string):string
cmt:=xtpl(cmt,[
      '&amp;', '&',
      '&lt;', '<',
      '&gt;', '>',
      '&quot;','"',
      '&#039;',''''
      ]);
if not isTemp() then
  begin
  comment:=cmt; // quite easy
  exit;
  end;
....

although in reality the previous conversion is not necessary, there is the problem of the codification of the languages of certain languages and their restitution.

an example is better than all explanations

how to define  comments in Russian characters, store them, and restore them correctly to the web page

this comment как возможная функция saved as %EF%B7%90%D0%BA%D0%B0%D0%BA %D0%B2%D0%BE%D0%B7%D0%BC%D0%BE%D0%B6%D0%BD%D0%B0%D1%8F %D1%84%D1%83%D0%BD%D0%BA%D1%86%D0%B8%D1%8F%EF%B7%AF in comments file

the question is how to force the creation of comment files in UTF8 and not in ANSI by default

Title: Re: version 2.4
Post by: rejetto on October 07, 2018, 10:17:55 AM
First of all, sorry for my misplaced comment :-[

don't worry at all, i perfectly understood the situation and took absolutely no offense or whatever.
Just as a side comment on the planned obsolescence, that's a very complex matter and i cannot discuss it extensively, i want just to say that the new version of the programming language has little to do with it. Each p.language, the abstract concept, have always evolved without requiring any faster computer by itself. So ES6 doesn't require a faster PC by itself. Of course this is entangled in the process of obsolescence, but it's just a pawn. We can have better software with old computers, within limits. Then other factors occur causing the obsolescence we know. While some of these factors are malicious, my opinion is that most are not.

Quote
I have a possible solution to all this: perhaps this could be fixed doing a small routine, that detects if the browser doesn't support "the => arrow functions" (or other 'ECMAScript 6' expressions), and then it 'dynamically translates' those functions/expressions with older JavaScript code. Doing this, you only do that routine once, and you don't have to change every function. What do you think?... :)

Sadly the translation is not as trivial as it seems. The software to make the conversion is big, and in general the effort is not worth the result.
Title: Re: version 2.4
Post by: rejetto on October 07, 2018, 01:05:16 PM
same bug  in previous versions,  the offender is discovered, it is necessary to correct the setcomment function of the template

        function setComment() {
            var value = it.find('.comment-text').html() || ''    // change .html() by .text()

thanks, the solution becomes complete simply by removing the {.encode html.} in the [ajax.comment]
Title: Re: version 2.4
Post by: rejetto on October 07, 2018, 01:28:36 PM
- Possible bug found #1: add a real folder, then on root set 'access' and 'delete' to anyone, then try to rename that folder trough the browser, and you will see that the - Possible bug found #2: add a real folder (with several sub-folders inside), give to those inside sub-folders a different comment to each folder. Now rename one of those
- Design issue?: if you give a comment to a folder, that comment gets displayed next to the folder path, without any design or indication that it's a comment.

all of these should be fixed in next release.

Quote
- Here (http://rejetto.com/forum/index.php?topic=13060.msg1064023#msg1064023) is another different bug report about comments.
this was already fixed, AFAIK
Title: Re: version 2.4
Post by: rejetto on October 07, 2018, 02:47:49 PM
http://www.rejetto.com/hfsfiles/hfs24b4.exe

give it a try
Title: Re: version 2.4
Post by: Mars on October 07, 2018, 05:54:09 PM
     {.set item|{.force ansi|%folder%{.^fn.}.}|comment={.force ansi|{.postvar|text.}.}.}

not working:   the tag <BR> always appears when editing the comment

however, what I proposed works despite everything

var value = it.find('.comment-text').text() || ''

Title: Re: version 2.4
Post by: rejetto on October 07, 2018, 08:24:28 PM
not working:   the tag <BR> always appears when editing the comment

strange, i just tested comments with multiple lines, and no problems at all.
Are you sure you are using the default template with no customization.
Do other people have problems?

when comments are saved in descript.ion, each line of comment is ended with code 0x04,0xC,x0D,x0A

yes, you can find a function explicitly adding the bytes, escapeIon()
Title: Re: version 2.4
Post by: Mars on October 07, 2018, 09:38:10 PM
Are you sure you are using the default template with no customization.
Do other people have problems?


Sorry, i was using the new template of  24b3 as external template new 24b4

yes, you can find a function explicitly adding the bytes, escapeIon()

that's what I understood but too late


EDIT:
@rejetto
do you think you can make a drop-down menu for the "more options" button instead of a central popup, as in the following image?


EDIT: hfs24b4 with internal template
I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item

EDIT:
a really strange thing, with the last exe in two different directories, on one the upload progress works but not the other, I realized that in the one that works I had a default.tpl while in the other I did not have it, I ended up comparing the default.tps of the first with the internal hfs.tpl of the second one, and I realized that réjetto had made a dumpling (fluff, stupidity)

by changing "upload-panel" by "upload panel" he had thus transformed $('#upload-panel') into $('#upload panel') leaving <div id="upload-panel"

EDIT:
@rejetto
do you think you can make a drop-down menu for the "more options" button instead of a central popup, as in the following image?
Title: Re: version 2.4
Post by: LeoNeeson on October 08, 2018, 12:02:23 AM
http://www.rejetto.com/hfsfiles/hfs24b4.exe

give it a try
I can't believe it! YOU DID IT! (https://i.imgur.com/Rr0Mejs.gif)
I had forgotten how amazing you are! :D

Now it works great from Chrome v19.0 to Chrome v31.0 (and beyond).

I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item
Changing:
Code: [Select]
.item-link { float:left; }
To:
Code: [Select]
.item-link { float:none; }
...seems to solve the problem. (https://www.w3schools.com/cssref/pr_class_float.asp)

by changing "upload-panel" by "upload panel" he had thus transformed $('#upload-panel') into $('#upload panel') leaving <div id="upload-panel"
I did notice that when I was doing a comparison between 'Build 2' vs 'Build 3' with DiffNow, but I didn't say anything because it thought it was a proper fix. By the way, with the last edition, he deleted this line (I don't know is has any effect, because it seems to work OK without that):
Code: [Select]
<link rel="stylesheet" href="/?mode=section&id=icons.css" type="text/css">
do you think you can make a drop-down menu for the "more options" button instead of a central popup?
That could be nice, but (IMHO) only as an option for desktop browsers, because I think on small screen devices, that could lead to usability problems (like clicking by mistake outside the menu and having to start again). Perhaps this can be done using only CSS, but distinguishing between mobile vs desktop by its size is not easy nowadays, since new devices have big screen resolution. As an idea, maybe a new 'mobile' icon can be added (along with the 'lightbulb'), to switch between mobile and desktop, so in the default mobile theme we can have the current modalbox, and in the desktop theme the dropdown proposed by Mars. But that's in the case Rejetto is interested on this.

how to define  comments in Russian characters, store them, and restore them correctly to the web page

this comment как возможная функция
On my PC (using the Build 4), that comment gets stored and displayed as:
Code: [Select]
??? ????????? ???????
...and my browser can display russian characters without problems. Perhaps unicode comments could be stored on Base64 (using `atob()` and `btoa()`). Just an idea...



In the dark theme, the 'foldercomment' needs his own CSS code (new line to add marked in red, and I've used a slightly different color to not to be confused with a file comment):
Quote
body.dark-theme .item .comment { background-color:#444; color:#888; }
body.dark-theme #foldercomment { background-color:#333; color:#999; }

I did a quick test, and it seems all the comment problems I've reported, are solved now (that's great!). :)
Title: Re: version 2.4
Post by: dj on October 08, 2018, 03:19:03 AM
works also with IE11

Quote from: Mars on October 07, 2018, 09:38:10 PM
I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item

Changing:
Code: [Select]
.item-link { float:left; }
To:
Code: [Select]
.item-link { float:none; }...seems to solve the problem.

This alone don't solve the problem just as a non transparent border (http://rejetto.com/forum/index.php?topic=13060.msg1064048#msg1064048) don't.
The checkboxes must be inserted before the link as already reported (http://rejetto.com/forum/index.php?topic=13060.msg1064021#msg1064021) (line 952 in the new tpl)

Quote
do you think you can make a drop-down menu for the "more options"
not a drop-down, but always vertical
Code: [Select]
[+common-head]
<style>
.item-menu-dialog {width: initial}
.item-menu-dialog .pure-button {display:block}
</style>
Title: Re: version 2.4
Post by: rejetto on October 14, 2018, 10:12:33 PM
do you think you can make a drop-down menu for the "more options" button instead of a central popup, as in the following image?

it would take time and i see no real gain

Quote
I am again confronted with a reported problem: check boxes checked have the same effect as clicking the name of the associated item

ok, i hope this time is fixed for real

Quote
by changing "upload-panel" by "upload panel" he had thus transformed $('#upload-panel') into $('#upload panel') leaving <div id="upload-panel"

fixed, thanks
Title: Re: version 2.4
Post by: rejetto on October 14, 2018, 10:23:50 PM
Perhaps unicode comments could be stored on Base64 (using `atob()` and `btoa()`).

that would break the descript.ion standard format, i guess

Quote
In the dark theme, the 'foldercomment' needs his own CSS code (new line to add marked in red, and I've used a slightly different color to not to be confused with a file comment):

thanks i'll use that
Title: Re: version 2.4
Post by: rejetto on October 14, 2018, 10:26:27 PM
i'm also going for the vertical item-menu suggestion

www.rejetto.com/hfsfiles/hfs24b5.exe

did you guys try the new forum template? it supports also dual dark/light mode, cool
Title: Re: version 2.4
Post by: Mars on October 14, 2018, 10:35:28 PM
another bug with comment ?? 

when creating or modifying a comment, the multilines are sent with LF and not with CRLF, therefore the comments of the items of the vfs, as well as those recorded in the ".comment" files are saved in the wrong format and do not appear more correctly in a new edition

the solution found is the following:

Quote
procedure Tfile.setDynamicComment(cmt:string);
var
  s, path, name: string;
  i: integer;
begin
if countSubstr(#13#10,cmt) = 0 then
  cmt:=xtpl(cmt,[#10,#13#10]);

if not isTemp() then
  begin
  comment:=cmt; // quite easy
  exit;
  end;

....
the bug is also effective in version of hfs24b5.exe

another unimportant detail
Quote
    function getAccountRedirect():string;
.....
    // if it's not a complete url, it may require some fixing
    // mod mars 10-2018
    result:=xtpl(result,['\','/']); // if result ansiStart with '\' not necessary to add '/' with  next line of code
    if not ansiStartsStr('/', result) then result:='/'+result;
    end; // getAccountRedirect
Title: Details pending for fixing on v2.4 Beta
Post by: LeoNeeson on October 23, 2018, 07:16:04 AM
Details pending for fixing on v2.4 Beta:

- jQuery: As Mars (http://rejetto.com/forum/index.php?action=profile;u=2913) also reported here (http://rejetto.com/forum/index.php?topic=13060.msg1064051#msg1064051) and also dj (http://rejetto.com/forum/index.php?action=profile;u=32265) commented here (http://rejetto.com/forum/index.php?topic=13060.msg1064059#msg1064059), and after several tests I did on this weekend, I've found that there is an important difference between jQuery v1.4.2 (released on 02/2010 (https://blog.jquery.com/2010/02/19/jquery-142-released/)) and v1.12.4 (released on 05/2016 (https://blog.jquery.com/2016/05/20/jquery-1-12-4-and-2-2-4-released/)) [and not only because there are six years of difference!]. If you do a quick test using old templates, everything 'seems' to be OK (on a superficial look), but if you do some deep and detailed tests, you will find that the functionality is NOT 100% the same (as some buttons get broken or either not display, since depend on functions not found or not compatible with jQuery v1.12.4). This is a serious problem, since this will broke many old templates. Possible solution: include v1.4.2 by default (like it was on v2.3m), and embed v1.12.4 as a section on the new template, calling it as: "/?mode=section&id=jquery.js" and then adding on the section [jquery.js|no log|cache] the jQuery v1.12.4 file. So, by default, when an old template needs jQuery (using "/?mode=jquery"), it will use v1.4.2, and everything will work. I think this is the most easy and elegant way to solve this and keep compatibility. Just my 5 cents.

- HFS.lng untranslated strings: As you already may noticed, there are only a few strings that currently can't be translated because the way the code is written (without this, we can't have a complete translation). You can easily spot and find those strings, if you use a dummy 'hfs.lng' translation file that I'm attaching to this post (it translates every string to 'xxxxxxxxxxxx', so, if you can read some text in English, then that text couldn't be translated and need a fix). Switch to expert mode to see all the untranslated menus and also open the VFS's Properties. To help you finding a solution, I've noticed that most 'dynamic' menus have this problem, except one: + Menu -> Limits -> "Connection inactivity timeout" (so the way that code is written, could help you to fix the rest of the code). Keep in touch if there is something I could do to help. :)
Title: Re: version 2.4
Post by: LeoNeeson on October 29, 2018, 10:20:43 PM
@Rejetto: Don't let my last comment stop you from continuing with v2.4 beta testings. I do understand that you want to modernize HFS, and make it (even more) awesome by delivering by default jQuery v1.12.4, so you can forget about this jQuery thing if you are not interested (after all this doesn't affect me directly, since I know how to 'patch' old templates to make them use old jQuery if I need). But please don't forget (if you have a few minutes to spare, on checking how we can translate those untranslated 'dynamic' menus (if you prefer I can open a new thread about this). And I could help you to edit the source code if you can point me out in the right direction on how to re-write those menus to make them translatable. My message doesn't mean I'm requesting a fix to those untranslated menus 'right now' (this could be fixed on future version, like v2.4b, v2.4c or v2.4d), not pressure at all! :)
Title: Re: version 2.4
Post by: rejetto on October 31, 2018, 04:48:33 PM
i just had less time lately, but i'm not stopped ;)
thanks for your tests with jquery. If it's breaking other templates i will consider to just use old version, as i doubt it is worth having both versions.
Can you please tell me what old template and what feature it breaks?
I don't really understand why you mentioned mars and dj in your argument: mars was just guessing, but he was not right, and dj was suggesting to stop using jquery, any version.

hfs.lng: i'll have a look at it. I have to check the documentation of the translator to see how dynamic strings must be handled, i don't know yet.
Title: Re: version 2.4
Post by: Mars on October 31, 2018, 10:03:49 PM
Quote from: rejetto
mars was just guessing, but he was not right
it's understandable, javascript gives me Urticaria on neurons  ;D
Title: Re: version 2.4
Post by: LeoNeeson on November 02, 2018, 08:38:23 AM
hfs.lng: i'll have a look at it. I have to check the documentation of the translator to see how dynamic strings must be handled, i don't know yet.
Oki Doki :) Keep me posted if you have any advance on this...

Can you please tell me what old template and what feature it breaks?
Oh! :-[ I haven't saved the results of my tests, so, I will have to make those tests again on this weekend, at least with the default old template (and report back the results).
Title: Re: version 2.4
Post by: LeoNeeson on November 03, 2018, 09:45:15 PM
Can you please tell me what old template and what feature it breaks?
I'm afraid you won't like to hear this: on modern browsers the functionality seems to be OK, but on old browsers it gets broken (and the problems are too many to list here, but they are mostly buttons or some sections that doesn't showing up). So, summarizing: if some user was using an old template on an old browser, it will be fucked up (will have a very limited functionality), but if he is using a modern browser, will see no difference (everything seems to work fine). So, it's up to you if you keep jQuery v1.12.4 (breaking the compatibility with old browsers), or use jQuery v1.4.2 (maintaining compatibility).
Title: Re: version 2.4
Post by: rejetto on November 04, 2018, 06:47:50 PM
i just tried the old default template with iron31, and these features work correctly:
- change comment
- rename
- archive of selection
- delete
- new folder

don't you remember if the problems were with the default template, or not?
Title: Re: version 2.4
Post by: Mars on November 04, 2018, 07:38:34 PM
 may be wrong but it must be about the compatibility of old default template with the new version of jquery
Title: Re: version 2.4
Post by: LeoNeeson on November 04, 2018, 08:42:37 PM
don't you remember if the problems were with the default template, or not?
may be wrong but it must be about the compatibility of old default template with the new version of jquery
Yes, the problem was about compatibility of old default template (of 2.3m) with the new version of jQuery v1.12.4.



The latest tests I did the other day, were only using the default template of 2.3m. Using Iron 31 worked fine (and anything more modern than that). When I said 'you won't like to hear this' it was because the compatibility problem was with 'really' old browsers, like Firefox 3.x and IE6 (and could be more old browsers).

I could report exactly what it fails (with screenshots), since I have access to those browsers (in case you care about). But those were 'action' buttons not showing up (in Firefox 3.x), and IE6 was working better (this surprised me), only having the file 'selection panel' doesn't showing up. It could be more missing, since I can't remember exactly all now.

I reported this is issue because the default template of v2.3m was working absolutely fine BEFORE with those old browsers (and because some users could be still using and depending on those old browsers), but like I've said on previous posts, this issue particularly doesn't affect me (one because I mostly use Iron 31 which works fine now, and second because I could patch the old template to use jQuery v1.4.2 in case I need). But that doesn't mean this issue still exists, and that it could affect other old custom templates too.



ANOTHER THING: I also discovered that the new template of v2.4 is not 100% compatible with the old jQuery v1.4.2. If my tests are not wrong (at least when using Iron 31), when using the new template with the old jQuery, you will find all the main buttons on the header missing, and the 'more options' menu not responding when clicking on it. So, I have my doubts now if this is worth all the hassle, just to keep jQuery v1.4.2. But if you fix the new template to be working with jQuery v1.4.2, then go ahead with jQuery v1.4.2 (this would be the best solution, if it's not too complicated for you to fix it).

That's why I leave this decision up to you. In my opinion, when you release v2.4 (if you want to keep jQuery v1.12.4), you should at least warn users that old templates could be broken when using a truly old browser. But the best solution (that's my suggestion only), would be fixing the new template of v2.4 to be working with jQuery v1.4.2 (so you could include jQuery v1.4.2 by default).

I'm attaching the new template of v2.4 with old jQuery v1.4.2 embedded on the same file, to make your tests easier (but don't rely on it, since I can't be sure if it's from Beta 4 or 5). You will find it doesn't work as expected...

I hope this helps... ;)
Title: Re: version 2.4
Post by: rejetto on November 04, 2018, 09:45:28 PM
ok, i see.
I don't see a good reason to support IE6 and FF3.
I understand your suggestion to use jquery 1.4 is also in favor of IE6 and FF3.
Title: Re: version 2.4
Post by: rejetto on November 04, 2018, 09:48:10 PM
http://www.rejetto.com/hfsfiles/hfs24b6.exe

Now we have sorting, and much more translatable strings.
Title: Re: version 2.4
Post by: LeoNeeson on November 05, 2018, 07:06:45 AM
ok, i see.
I don't see a good reason to support IE6 and FF3.
I understand your suggestion to use jquery 1.4 is also in favor of IE6 and FF3.
Yeah, it's OK. :) Who cares about IE6 and FF3 anyway? They are not relevant today (I don't use it at all, I just did some tests on it, only because the old template worked fine on it). But if some user needs support for those old browsers, could still use 'The really fast Throwback (retro) template (http://rejetto.com/forum/index.php?topic=12055.0)' or the old legacy template that I'm sharing HERE (https://rejetto.com/forum/index.php?topic=13082.0). After all, this is a brand new version, so, it's OK to drop support for those 'truly very-old browsers'.

http://www.rejetto.com/hfsfiles/hfs24b6.exe

Now we have sorting, and much more translatable strings.
Cool! 8) I'll check it out and do some tests on the next few days...
Title: Re: version 2.4
Post by: MarkV on November 08, 2018, 10:37:16 PM
Hi, just passing by, and I see you are all still busy. HFS has come a long way (I still remember the good old days when it started). No reason to stop it. :)
Title: Re: version 2.4 feature request update - revamp
Post by: bmartino1 on November 09, 2018, 11:23:15 PM
Sorry, been out the past month or so with medical issues... i was going to post some things regardeing testing and other stuff. But for now, id like to add a potential change if applicable to the new beta.

The main idea is adding "a cookie-based login system", so modern mobile browsers could use a form based login system (and not rely on that old and obsolete login popup that most new browsers are now deprecating).

it would be nice to propose new additions (at server level).

I think it would be the perfect time to request having a "cookie-based login system" instead of (using a form based user/pass login).
--This way controls to login in and out can potential be code for a full login / logout function.

Delphi google searches for codes groups and info:

http://coding.derkeiler.com/Archive/Delphi/comp.lang.pascal.delphi.misc/2004-10/0357.html

http://groups.google.com.mx/group/borland.public.delphi.internet.winsock/browse_thread/thread/929c7359d8e321d7/e250f2e8f245ef0e?lnk=st&q=&rnum=1&hl=es#e250f2e8f245ef0e

http://codeverge.com/embarcadero.delphi.tools/how-to-use-indy-10-to-post-to-a-web/1066980

https://www.example-code.com/delphiDll/http_addCookies.asp

https://softwareengineering.stackexchange.com/questions/178105/understanding-http-cookies-in-indy-10-for-delphi-xe2

*essential adding more authentication (things i have seen at the windows server level):
https://www.example-code.com/delphiDll/http_authentication.asp
--(Delphi DLL) HTTP Authentication (Basic, NTLM, Digest, Negotiate/Kerberos)

**********************************
Although a "cookie-based login system" could be done at client level (only using JavaScript and Ajax)
https://www.codementor.io/mayowa.a/how-to-build-a-simple-session-based-authentication-system-with-nodejs-from-scratch-6vn67mcy3

https://stackoverflow.com/questions/42843030/javascript-login-using-cookies

https://www.htmlgoodies.com/beyond/javascript/article.php/3888551/JavaScript-Class-How-Can-I-Set-A-Cookie-Based-On-A-Users-Selection-On-A-Form.htm

https://developer.atlassian.com/cloud/jira/platform/jira-rest-api-cookie-based-authentication/

The main idea is adding "a cookie-based login system", so modern mobile browsers could use a form based login system (and not rely on that old and obsolete login popup that most new browsers are now deprecating).

Title: Re: version 2.4
Post by: Chris Harris on November 10, 2018, 04:41:46 AM
Just installed hfs24b6.exe and the interface is clean and very easy to use.

Thanks
Chris
Title: Re: version 2.4
Post by: Fysack on November 11, 2018, 12:20:13 AM
" latest tests I did the other day, were only using" Strighten up Leo. We can absolutely not use that in season 5 Le Bureau
Title: Re: version 2.4
Post by: LeoNeeson on November 11, 2018, 03:26:26 AM
" latest tests I did the other day, were only using" Strighten up Leo. We can absolutely not use that in season 5 Le Bureau
That's a 'high' post!! (https://i.imgur.com/NSJPeHf.gif)(https://i.imgur.com/bHTRoCG.gif)
Title: Re: version 2.4
Post by: LeoNeeson on November 11, 2018, 03:28:45 AM
http://www.rejetto.com/hfsfiles/hfs24b6.exe

Now we have sorting, and much more translatable strings.
Could you please generate a new base language file (hfs.lng), because I've generated a new one (using kdlscan.exe and lngupdate.exe), but I can't find any new string to translate (and neither any new modification is found). The utility kdlscan.exe mark with "(!)" every untranslated (new & modified) string, but in this case (and after doing every step right), it does't find new or modified strings. Are you sure there are new strings to translate? (because also after doing a 'visual' inspection, I don't see anything new/changed). ???



• Another thing: When using your new template on a desktop PC with a screen resolution of 800x600px, your new 'Sorting' button makes the 'menu-bar' look ugly (like this (http://i.imgur.com/kN3lBab.png)). I guess a small change needs to be done, so if that resolution is used, then show up the short/small mobile buttons instead.

You could solve this, changing 48em to 50em (http://pxtoem.com/):

Quote
@media (min-width: 50em) {
#toggleTs { display: none }
}
@media (max-width: 50em) {
#menu-panel button { padding: .4em .6em; }
.additional-panel button span,
#menu-bar button span { display:none } /* icons only */
#menu-bar i { font-size:120%; } /* bigger icons */
#menu-bar button { width: 3em; max-width:10.7vw; padding: .4em 0; }
.hideTs .item-ts { display:none }
}

...or using another method you want, so when 7 buttons are displayed on a small screen (800x600), the small buttons are shown.



• Another thing more: "developer notes.txt" needs this line to be added:
Code: [Select]
Kryvich's Delphi Localizer https://sites.google.com/site/kryvich/localizer


Sorry, been out the past month or so with medical issues. [...] the main idea is adding "a cookie-based login system", so modern mobile browsers could use a form based login system (and not rely on that old and obsolete login popup that most new browsers are now deprecating).
I hope you are well now, it's nice to see you again. :) I agree, that would be great. After seeing your post I've search on the forum and found out that Rejetto was working some time ago on a similar solution, but then he didn't say anything about it. This (http://rejetto.com/forum/index.php?topic=9699.msg1054351#msg1054351) was that post:

1. cookie authentication is on the way. Sadly i had to stop few months ago because of the lack of time. It's harder than you may think since i'm making it backward compatible, so that current templates will continue to work. It's already quite working but i have to solve some problems. Sharing it with you may be a good idea to speed up the process.
I know that post was -very- old, but may be rejetto has somewhere stored a partial-done code for a 'cookie authentication' system, that he could share it "as is" here, so we can continue developing it. ;)