rejetto forum

Software => HFS ~ HTTP File Server => Beta => Topic started by: rejetto on February 27, 2009, 10:48:51 PM

Title: Testing build #228
Post by: rejetto on February 27, 2009, 10:48:51 PM
(sorry for the #227  ::))

download @ www.dovedove.it/hfs/hfs228.exe

what's new
+ {.from table|$section|key.} will now work on [sections] as it did for variables
+ improved Windows links support (*.lnk)   
+ new template macro: set table
* {.get|can archive.} even in [file] will always refer to the folder. Use {.get|can archive item.} instead
- {.time.} broken in build #223 [link] (http://www.rejetto.com/forum/?topic=6696)
- virtual files inside real folders were not working with folder archive
- single files could be downloaded via folder archive without necessary permissions
- file properties graphical glitches [link] (http://www.rejetto.com/forum/index.php?topic=6689.msg1041183#msg1041183)
Title: Re: Testing build #228
Post by: Mars on February 28, 2009, 12:44:58 AM
My solution which you resumed  for 227 is incomplete because it takes back the completeness of the text of the sharing and not only the name of the sharing

sharing name : folder1

vfsname : folder1 on computer xxx

it is not good
Quote
  if fn = '' then continue;
  if isExtension(fn, '.lnk')                                 //add by mars
    or directoryExists(fn) and fileExists(fn+'\target.lnk')  //add by mars
    then fn:=resolveLnk(fn);                                 //add by mars  f:=Tfile.create(fn);
  if f.isFolder() then

into utillib.pas , the update in not enough
the text in blue is really necessary ;)
Title: Re: Testing build #228
Post by: Mars on February 28, 2009, 01:28:01 AM
big  ;D
Quote
<html>
<body>
{.^$mars.}
{.if not|{.^$mars.}|  You have to init it by 'FROM TABLE' with a bad request.}
<br>
{.from table|$mars|mars.}
{.^$mars.}
<hr>
{.from table|$mars|li2.}
<br>
{.^$mars.}
<br>
{.$mars.}
</body>
</html>

[mars]
li1=line1
li2=line2
li3=line3

give :
Quote
You have to init it with 'FROM TABLE'
li1=line1 li2=line2 li3=line3
--------------------------------------------------------------------------------
line2
li1=line1 li2=line2 li3=line3
li1=line1 li2=line2 li3=line3


GOOD :two ways to call sections ;)

OOPS, I do not believe that it is going to please in rejetto, him who does not love the doubles. ;D ;D ;D ;D

Title: Re: Testing build #228
Post by: rejetto on February 28, 2009, 01:10:12 PM
My solution which you resumed  for 227 is incomplete because it takes back the completeness of the text of the sharing and not only the name of the sharing

Quote
  if fn = '' then continue;
  if isExtension(fn, '.lnk')                                 //add by mars
    or directoryExists(fn) and fileExists(fn+'\target.lnk')  //add by mars
    then fn:=resolveLnk(fn);                                 //add by mars 
f:=Tfile.create(fn);
  if f.isFolder() then

do you see the Tfile.create?
it calls Tfile.setResource, which is checking for "target.lnk".
so, the work is done anyway.

Quote
sharing name : folder1
vfsname : folder1 on computer xxx

i tested this, and found a bug, but a different one:
folder1\folder2  ->  folder1
anyway, this has been fixed for next build. I can give a preview if you want to test and see if your problem has consequentially been fixed.
Title: Re: Testing build #228
Post by: rejetto on February 28, 2009, 01:15:14 PM
OOPS, I do not believe that it is going to please in rejetto, him who does not love the doubles. ;D ;D ;D ;D

in programming you usually have many ways of doing things.
but the tools should not overlap intentionally. it's a side effect. ;)
Title: Re: Testing build #228
Post by: Mars on February 28, 2009, 06:26:37 PM
Since the last modifications concerning the drag and drop, the warning on doubloons does not appear any more, what makes that a big part of the code of the procedure became useless

Quote
{
// warn upon double filenames
doubles:=NIL;
s:=files;
while s > '' do
   begin
  fn:=chopLine(s);
  if isExtension(fn, '.lnk')
//  or directoryExists(fn) and fileExists(fn+'\target.lnk') // mod by mars
  then fn:=resolveLnk(fn);

  if (length(fn) = 3) and (fn[2] = ':') then fn:=fn[1]+fn[2] // unit root folder
   else fn:=ExtractFileName(fn);
mainfrm.add2log(fn);
  if existsNodeWithName(fn, under) then
    if addString(fn, doubles) > MAX_DUPE then
      break;
  end;
if assigned(doubles) then
  begin
  filesBox.Repaint();
  res:=length(doubles);
  s:=if_(res > MAX_DUPE, intToStr(MAX_DUPE)+'+', intToStr(res));
  s:=format(MSG1, [s, join(', ',doubles)]);
  if msgDlg(s, MB_ICONWARNING+MB_YESNO) <> IDYES then exit;
  end;
}

with it or whitout the result is the same, an duplicate name is incremeted (x+1) without warning


Quote
I tested this, and found a bug, but a different one:
folder1\folder2  ->  folder1
anyway, this has been fixed for next build. I can give a preview if you want to test and see if your problem has consequentially been fixed.
Yes you can and you have to do it ;)
Title: Re: Testing build #228
Post by: rejetto on February 28, 2009, 06:38:29 PM
with it or whitout the result is the same, an duplicate name is incremeted (x+1) without warning

the check for "doubles" was made mainly to give the user the message dialog.
when you add 2 files with same name in the same folder, it's likely you are going in troubles, so better be warned.


Quote
Yes you can and you have to do it ;)

ok, coming!
Title: Re: Testing build #228
Post by: FRENCH CAN CAN on February 28, 2009, 08:41:49 PM
Bugs in this version, the archive is corrupted.

Bug anche in questa versione, l'archivio รจ danneggiato.

Screenshot:
Title: Re: Testing build #228
Post by: Mars on March 01, 2009, 11:27:40 PM
I agree FRENCH CAN CAN.

 rejetto, you have to do an other version of servetar the last one is very very bad

selection(boolean) is not defined correctly at the end of addSelection(); and some subdirs or files in a real folder are not included or total size not correct :(
Title: Re: Testing build #228
Post by: r][m on March 02, 2009, 04:13:35 AM
This may not be revelant to topic but heres what I see.

I have protected virtural folder A. Inside is protected real folder B. Then inside B is C, then inside C is D.
Files inside D produce corrupt .tar of 512k. Move the files up to C, the .tar is OK
They download OK from D as single files. Test done with known good files.

After downloading .tar using default tpl with 228, check boxes remain checked after
download is completed. Any furthur action on the folder/page causes the download
to start again.

Selectable delete works in diff tpl, but after adding new selectable archive section, neither work.
Both work in main tpl.
Title: Re: Testing build #228
Post by: jerome on March 03, 2009, 05:45:24 AM
hello,
a new behavior in the user account option for this version.
the user accounts ignore limits OFF function works only after a vfs save.
when ignore limit ON works directly.

Title: Re: Testing build #228
Post by: chthonic on March 05, 2009, 10:35:44 PM
the only odd thign I have noted on my end is that the Live Template no longer functions with this build.

[suggestion]
add an option to force URL links to: target=_blank

this would be less hassle than searching the template code and adding the string if it does not exist.
Title: Re: Testing build #228
Post by: crazyboris on March 07, 2009, 11:06:03 AM
if you password protect a file and choose only to show passwordprotected files to logged in users.

if you do a search for that file it comes up in the list and can be downloaded without password.
so if you are a random user just doing a random search you can get access to protected files.
Title: Re: Testing build #228
Post by: Alekc on March 07, 2009, 04:49:17 PM
When I'm starting a file download with Google Chrome, and then abort it (at the prompt where to save) - HFS hangs up trying to send me this file.
I know, GC is a beta too, but...

All worked ok on IE7.
Title: Re: Testing build #228
Post by: r][m on March 07, 2009, 05:56:37 PM
crazyboris
Quote
if you password protect a file and choose only to show passwordprotected files to logged in users.

if you do a search for that file it comes up in the list and can be downloaded without password.
so if you are a random user just doing a random search you can get access to protected files.

That doesn't happen here (as far as my testing shows).
Could you give us more details on how you are doing this? What template and search code, etc.
It is of some concern to me, at least.
Title: Re: Testing build #228
Post by: chthonic on March 07, 2009, 06:17:01 PM
login hangs in firefox 3.07 if you type the wrong password.. it wont let you in at all.. but the problem doesn't happen in IE7

wasnt a problem with 3.06.. but not sure if its an issue with FF or HFS
Title: Re: Testing build #228
Post by: cmatte on March 08, 2009, 01:34:52 AM
login hangs in firefox 3.07 if you type the wrong password.. it wont let you in at all.. but the problem doesn't happen in IE7

wasnt a problem with 3.06.. but not sure if its an issue with FF or HFS
Mmh I'm using 3.0.7 and it does not hang if I put the wrong password, it simply asks for it again and shows the normal access denied page if you choose cancel..
Title: Re: Testing build #228
Post by: maverick on March 08, 2009, 04:35:56 AM
login hangs in firefox 3.07 if you type the wrong password.. it wont let you in at all.. but the problem doesn't happen in IE7

wasnt a problem with 3.06.. but not sure if its an issue with FF or HFS

No problems here either with FF 3.07 and HFS.
Title: Re: Testing build #228
Post by: crazyboris on March 08, 2009, 09:22:15 AM
i was wrong the folder i put a password on had a copy inside another folder that wasent password protected.

so i had a exact copy of my folder inside another folder , and there was no pass on that.
thats why my "protected" files showed up..   :-[
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 01:26:27 AM
i was wrong the folder i put a password on had a copy inside another folder that wasent password protected.

so i had a exact copy of my folder inside another folder , and there was no pass on that.
thats why my "protected" files showed up..   :-[

ok CB, we are happy this way, thank you for reporting :)
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 01:27:15 AM
login hangs in firefox 3.07 if you type the wrong password.. it wont let you in at all.. but the problem doesn't happen in IE7
wasnt a problem with 3.06.. but not sure if its an issue with FF or HFS

since other people cannot reproduce your problem, could you test it on another computer?
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 01:56:49 AM
guys, i cannot reproduce this TAR problem.
could you please provide a screenshot of the virtual file system, and a corrupted tar file?
send to support@rejetto.com
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 02:03:19 AM
After downloading .tar using default tpl with 228, check boxes remain checked after
download is completed. Any furthur action on the folder/page causes the download
to start again.

this is how it is supposed to work.
if you want it to reset the selection by default, you can make a new poll (instead of "new topic") here on the forum.

anyone wishing to customize the behavior can change the onclick of the archive button to this

Code: [Select]
if (!confirm("Are you sure?")) return false;
submitAdding("filelist", {"action":"archive"}, "~folder.tar?recursive");
var is = document.getElementsByName("selection");
for (var i=0; i < is.length; i++) is[i].checked = false;

Quote
Selectable delete works in diff tpl, but after adding new selectable archive section, neither work.
Both work in main tpl.

in diff tpl? please tell me how to configure HFS to reproduce your problem.
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 02:07:50 AM
selection(boolean) is not defined correctly at the end of addSelection();

ah, right, i will put this at the very beginning
selection:=FALSE;

Quote
and some subdirs or files in a real folder are not included or total size not correct :(

is this problem related to the value of selection:boolean ?
if not, can you tell me how to reproduce it ?
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 02:17:42 AM
the only odd thign I have noted on my end is that the Live Template no longer functions with this build.

mmm, so it works if you revert to the last known working build?

Quote
add an option to force URL links to: target=_blank

lets discuss it at http://www.rejetto.com/forum/index.php?topic=6640.msg1041478#msg1041478
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 02:29:14 AM
a new behavior in the user account option for this version.
the user accounts ignore limits OFF function works only after a vfs save.
when ignore limit ON works directly.

i just tested. removed the "ignore limits" from an account, and it was applied without a vfs save.
problem is/was that it required the connection to be reset. you could close all active connections, and then it was applied.
solved from next build.
Title: Re: Testing build #228
Post by: rejetto on March 10, 2009, 02:37:11 AM
When I'm starting a file download with Google Chrome, and then abort it (at the prompt where to save) - HFS hangs up trying to send me this file.
I know, GC is a beta too, but...
All worked ok on IE7.

thanks for reporting, but there's nothing HFS can do with it. It's a bug of Chrome that has to be reported to google. The server doesn't know that you cancel or accept at the prompt.
Title: Re: Testing build #228
Post by: chthonic on March 10, 2009, 12:21:04 PM
login hangs in firefox 3.07 if you type the wrong password.. it wont let you in at all.. but the problem doesn't happen in IE7
wasnt a problem with 3.06.. but not sure if its an issue with FF or HFS

since other people cannot reproduce your problem, could you test it on another computer?

it's definitely a problem with FF on "some" machines... the login box doesnt always refresh itself and it keeps hanging on the mistyped password because its still in the buffer.. closing out the browser completely and reloading fixes the issue.
Title: Re: Testing build #228
Post by: r][m on March 11, 2009, 06:25:44 AM
anyone wishing to customize the behavior can change the onclick of the archive button to this

Code: [Select]
if (!confirm("Are you sure?")) return false;
submitAdding("filelist", {"action":"archive"}, "~folder.tar?recursive");
var is = document.getElementsByName("selection");
for (var i=0; i < is.length; i++) is[i].checked = false;

Alright ! ;D Workarounds are good ! The code above works (of course).
I thank you and my less than expert users thank you !