2 Possible BUGs (URL encoding + Recursive file listing)

[psyxakias]

Hello,

I have noticed the following issues which both are occuring with recursive file listing:

1) If I enable "Include passwords in pages", the links are indeed showed normally (http://user:pass@rest-url) when clicking the URLs inside a folder. BUT when I click "File List" from inside a folder to recursive list all URLs, it generates a non-sense URL which of course doesn't work: http://path/http://user:pass@rest-url (yah that's not a typo from me, two http:// in a single URL)

Re-production:
- Enable "Include password in pages" (Menu > URL encoding > [CHECKED] Include password in pages)
- Going to http://1.2.3.4:2000/Dir1/Dir2/Dir3/ (after authenticating with testuser/testpass)
- Clicking "File List" which redirects me to: http://1.2.3.4:2000/Dir1/Dir2/Dir3/?tpl=list&recursive
- Generated URLs are like that (yes with two http:// !):
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:<encodedpass>@1.2.3.4:2000/Dir1/Dir2/Dir3/file1.jpg
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:<encodedpass>@1.2.3.4:2000/Dir1/Dir2/Dir3/file2.jpg
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:<encodedpass>@1.2.3.4:2000/Dir1/Dir2/Dir3/file3.jpg
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:<encodedpass>@1.2.3.4:2000/Dir1/Dir2/Dir3/file4.jpg
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:<encodedpass>@1.2.3.4:2000/Dir1/Dir2/Dir3/file5.jpg

2) If I disable "Unreadable passwords in URLs", the links are indeed showing readable passwords when I check the URLs inside a folder. BUT when I click "File List" to recursive list all URLs, the passwords are unreadable with encoded (%XX) characters.

Re-production:
- Enable "Include password in pages" (Menu > URL encoding > [CHECKED] Include password in pages)
- Disable "Unreadable passwords in URLs" (Menu > URL encoding > [UNCHECKED] Unreadable passwords in URLs)
- Going to http://1.2.3.4:20000/Dir1/Dir2/Dir3/ (after authenticating with testuser/testpass)
- Clicking "File List" which redirects me to: http://1.2.3.4:2000/Dir1/Dir2/Dir3/?tpl=list&recursive
- Generated URLs have encoded passwords:
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:%6D%6D%6D%6D@1.2.3.4:2000/Dir1/Dir2/Dir3/file1.jpg (%6D is an example)
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:%6D%6D%6D%6D@1.2.3.4:2000/Dir1/Dir2/Dir3/file2.jpg (%6D is an example)
http://1.2.3.4:2000/Dir1/Dir2/Dir3/http://testuser:%6D%6D%6D%6D@1.2.3.4:2000/Dir1/Dir2/Dir3/file3.jpg (%6D is an example)

Thank you.

PS: I am using HFS 2.3 beta #144 and I have even tried to restart HFS after enabling/disabling these options, no change.

[rejetto]

thank you for the excellent report

bug1 fixed in next build

bug2 is not exactly a bug. When creating that option i thought it was not useful inside file listings, so i kept them encoded. So it may be considered unclear the description. I wait for opinions and suggestions.

[psyxakias]

Thanks for the quick response, rejetto.

I don't know if that should actually be a feature request: The reason I wanted unencoded passwords in recursive listing is that I have been trying to make a list of mp3s located into an HFS web server (with authentication), in order to put them into a .m3u and play them in Winamp but Winamp doesn't play the encoded ones, that's why I reported it as bug. Is there any easier way to do that or I better check some HFS plugin (I think I had seen something for mp3s) for such usage?

[rejetto]

i know of several people who use the file list as play list, so although i consider it a winamp's bug (and i invite you to report it to nullsoft), for now i will just make the option affect the file list, since the reason for it is not currently affecting is not very important.
from next build.