rejetto forum

Testing build #208

rejetto · 36 · 19546

0 Members and 1 Guest are viewing this topic.

Offline TCube

  • Tireless poster
  • ****
    • Posts: 440
    • View Profile
1 - Dont log
2 - No it either starts with http:// Ip adress or http://127.0.0.1 - Giving  a try setting a personal adress as %host% and it now works  ;)
« Last Edit: October 17, 2008, 12:46:59 PM by TCube »
Make it idiot-proof and I will make a better idiot


Offline chthonic

  • Tireless poster
  • ****
    • Posts: 121
  • I own the copyright to this image... "Back Off!"
    • View Profile
hi.. and yes.. I am still alive! I have just been very busy with legal stuff.

I like that you have started working on the "groups" feature.... but.. there are some serious and time consuming issues with the way you have it coded.

I am not sure what you changed between 207 and 208 ..but in 208 I can no longer designate more than one group having access to a set of files.. the one will show to a user.. but the others wont.. if I go back to a single group.. they all show up.... this is very bad LOL

going to offer a suggestion one that's faster and can be handled all in one window.. namely the user accounts..

#1: do not link groups to listed files!! only use them to organize users.. then allow <add new user> to each specific group as a child of that group. [add group]=auto configures a new group [add user] etc if a group is selected then [add user] creates it as a group child rather than a root... like how guildftp works... you could add [create orphan] which places a user strictly in the accounts/groups root

#2: listed files are invisible to all by default.

#3: when creating a user account, allow the feature you are using to link groups to select the files that are in the VFS tree instead.. "folders and individual files".... like how emule plus allows you to select sharing folders, with the same option to CTRL+CLICK to select all subfolders/items etc

still keep the restrict access option in the right click sub menu of the vfs tree for on-the-fly configuration

(addition)..... have a sub window open in tree view showing account names only with check boxes and a button for OK and CANCEL... this will save time as well .. it would let us link new files and folders to multiple accounts in a single task. ??? ;D :-\

(addition2) hmm this idea could also work for adding new files or folders.. especially where virtual folders are involved.. I cna just check the folders to add instead of HFS loading ever single folder in the path.. wont have to fuss around later to remove unwanted folders.

if we can control user access at the account creation level .. it goes much faster and we can customize the file access for each specific user.... it would eliminate all the switching back and forth with each individual file/folder withe current method.. which is "one at a time".
***********
additional item noticed.... when deleting a group it changes any user account above or below to a group,.....
« Last Edit: October 18, 2008, 08:17:51 PM by chthonic »


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2059
    • View Profile
Quote
It is possible to get Url starting with http://%host%

Menu > Ip Address >Custom...

add this to resolve your question ;)

%host%
127.0.0.1
« Last Edit: October 17, 2008, 05:38:45 PM by mars »


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2059
    • View Profile
load this version build 208, and comment it, please. Thanks

http://hfs.webhop.org/hfs_accounts_rights_icons.exe

look at picture

accounts are not checked but have icons,

when an icon is black and white then account is not checked
when an icon is in color

1) with 'via', account is not checked but as rights access through account linked
2) with only account name then account is checked

 ;)  I hope rejetto like it (or love it) ;D

The solution of this sleight of hand, everything is situated in main.pas
 
Quote

const
  VERSION = '2.3 beta';
  VERSION_BUILD = '208';
  ........
  TAB = #9;
  {The choice of this constant is important for separating the account name from the rest. All for the good functioning of the code}
  MCHAR=' ->';                              //add by mars
  BAK_EXT = '.bak';
  ......

*********************************
  procedure buildPermissionMenu(mi:Tmenuitem; action:TfileAction);
  var
    i: integer;
    g: boolean;             //add by mars

  function getlinked(i:integer; act: TfileAction):string;      //add by mars
  { all this function  is and update from  loadAccountProperties() }

    var
      f:Tfile;
      a, other: Paccount;
    begin
    a:=@accounts;
    result:='';
    f:=selectedfile;
    if f=nil then exit;
    if not stringExists(USER_ANY_ACCOUNT, f.accounts[act]) then
      begin
      other:=findEnabledLinkedAccount(a, f.accounts[act]);
      if other = NIL then exit;
      if other <> a then
        result:=MCHAR+' via '+other.user;
      end;
    end;         //add by mars  all this function


  begin
  mi.clear();

  if length(accounts) > 1 then
    begin
    mi.add( newItem( 'All existing accounts', 0, FALSE, TRUE, permissionMenuClick, PERMISSIONMENU_ALL_ACCOUNTS, '') );
    mi.add( newItem( 'No account', 0, FALSE, TRUE, permissionMenuClick, PERMISSIONMENU_NONE, '') );
    end;

  anyone:=stringExists(USER_ANYONE, all_accounts[action]);
  if action <> FA_ACCESS then mi.add( newItem('Anyone', 0, anyone, TRUE, permissionMenuClick, PERMISSIONMENU_ANYONE, '') );
  mi.add( newItem('Any account',0, stringExists(USER_ANY_ACCOUNT, all_accounts[action]), TRUE, permissionMenuClick, PERMISSIONMENU_ANY_ACCOUNT, '') );
  mi.add( newItem( 'New account...', 0, FALSE, TRUE, permissionMenuClick, PERMISSIONMENU_NEW_ACCOUNT, '') );
  mi.add( newItem('-',0,FALSE,TRUE,NIL,0,'') );

  if action = FA_ACCESS then mi.add( newItem(USER_ANONYMOUS,0, stringExists(USER_ANONYMOUS, all_accounts[action]), TRUE, permissionMenuClick, PERMISSIONMENU_ANONYMOUS, '') );


{debut modif mars}
  for i:=0 to length(accounts)-1 do
     with accounts do
          begin
            mi.add( newItem(user+getlinked(i,action), 0, not anyone and stringExists(user,all_accounts[action])      //mod by mars
               , not anyone and enabled, permissionMenuClick, 0, '')) ;               // Do not forget to put the semicolon
            g:=stringExists(user,all_accounts[action]) or (pos(MCHAR,mi.Items[mi.Count-1].Caption)>0);   //add by mars
            if not anyone then mi.Items[mi.Count-1].ImageIndex:=if_(group, if_(g,29,40), if_(g,27,28)); 
//add by mars
          end;
  end;
{fin de modif mars}
........

********************
procedure Tmainfrm.permissionMenuClick(sender:Tobject);
.......
case mi.helpContext of
  PERMISSIONMENU_ALL_ACCOUNTS:
    begin
    username:='';
    if all = NIL then exit;
    end;
  PERMISSIONMENU_NONE: username:='';
  PERMISSIONMENU_ANYONE: username:=USER_ANYONE;
  PERMISSIONMENU_ANY_ACCOUNT: username:=USER_ANY_ACCOUNT;
  PERMISSIONMENU_ANONYMOUS: username:=USER_ANONYMOUS;
  PERMISSIONMENU_NEW_ACCOUNT:
    begin
    acc:=createAccountOnTheFly();
    if acc = NIL then exit;
    username:=acc.user;
    end;
  else
    begin                                 //add by mars
     username:=mi.Caption;                //mod by mars
     username:=chop(MCHAR,username);      //add by mars
    end;                                  //add by mars

  end;
if (action = FA_ACCESS)
and ((username > '') and not mi.Checked or (mi.helpContext = PERMISSIONMENU_ALL_ACCOUNTS)) // we are protecting something
and fileAttributeInSelection(FA_LINK)
and (msgDlg(MSG_UNPROTECTED_LINKS, MB_ICONWARNING+MB_YESNO) <> IDYES) then exit;


« Last Edit: October 18, 2008, 09:37:58 PM by mars »


Offline traxxus

  • Occasional poster
  • *
    • Posts: 62
    • View Profile
With rejettos buld 208 i cant add accounts (hfs tells me, "account already exist)

@mars

your version works, no problems.
traxxus.dyndns.org:100


Offline Pit

  • Tireless poster
  • ****
    • Posts: 115
    • View Profile
    • EDV & Netzwerkservice in Berlin
I can add and delete accounts with the build 208 from rejetto.
You reach our Webserver every day between 9 AM to 10 PM under: http://phampel.dyndns.org or http://free4you.dyndns.org


Offline chthonic

  • Tireless poster
  • ****
    • Posts: 121
  • I own the copyright to this image... "Back Off!"
    • View Profile
I can add and remove accounts.. tho I did have this problem with a previous version... I just closed out HFS waited 2 minutes and loaded it back up... after that it was fine.


Offline bacter

  • Operator
  • Tireless poster
  • *****
    • Posts: 681
    • View Profile
it would be nice if the account sorting would not be case sensitive (as accounts are not case sensitive).
your computer has no brain - use your own !


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2059
    • View Profile
Quote
Topic Summary
Posted on: Today at 06:15:34Posted by: bacter 
Insert Quote
it would be nice if the account sorting would not be case sensitive (as accounts are not case sensitive).
 

Made by leaving to the user the possibility of the choice ;)

http://hfs.webhop.org/hfs_accounts_sorting.exe


SortSensitiveChk is a TcheckBox

Quote
  function sortIt(reverse:boolean=FALSE):boolean;
  var
    s, i, j, l: integer;
  begin
  result:=FALSE;
  s:=accountsBox.ItemIndex;
  l:=length(tempAccounts);
  for i:=0 to l-2 do
    for j:=i+1 to l-1 do
      if reverse XOR (
      (SortSensitiveChk.checked and (tempAccounts.user > tempAccounts[j].user))
       or
      (not SortSensitiveChk.checked and (ansiCompareText(tempAccounts.user,tempAccounts[j].user)>0))
       ) then

        begin
        swapMem(tempAccounts, tempAccounts[j], sizeof(tempAccounts[0]));
        if i = s then
          s:=j
        else if j = s then
          s:=i;
        result:=TRUE;
        end;
  accountsBox.ItemIndex:=s;
  end; // sortIt
« Last Edit: October 19, 2008, 10:55:47 AM by mars »


Offline SilentPliz

  • Operator
  • Tireless poster
  • *****
    • Posts: 1298
  • ....... chut ! shh!
    • View Profile
Made by leaving to the user the possibility of the choice ;)

http://hfs.webhop.org/hfs_accounts_sorting.exe


Because now we can choose our version of HFS...

I want one version that prepares breakfast.
I could stay longer in bed with my girlfriend. ;) ;D
« Last Edit: October 19, 2008, 11:33:32 AM by SilentPliz »


Offline Mars

  • Operator
  • Tireless poster
  • *****
    • Posts: 2059
    • View Profile
Quote
I want one version that prepares breakfast.
I could stay longer in bed with my girlfriend. 

With an option for the regulation of the cooking
...

Still you would have to deign to go to bed in the marriage bed and not on the sofa in front of the computer  :D

I believe that we are going eventually make it eject some forum if we continue our verbal extravagances ;)


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13510
    • View Profile
1 - Dont log

i tested it and it worked for me.
i selected 2 virtual and 1 real folder, enabled, disabled the "don't log". never failed.
see if the problem is in your french version, or find a way to make me reproduce it.

Quote
2 - No it either starts with http:// Ip adress or http://127.0.0.1 - Giving  a try setting a personal adress as %host% and it now works  ;)

i made a quick test.
if i defined a customized address, even if it is not selected as the default one, it appears in the list "copy url with different host address".
let me know if there's any problem at all or it was just inattention.


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13510
    • View Profile
it would be nice if the account sorting would not be case sensitive (as accounts are not case sensitive).

fixed in next beta


Offline TCube

  • Tireless poster
  • ****
    • Posts: 440
    • View Profile
Rejetto you're right. Thks for testing . My concentration might 've been a bit loose.
Make it idiot-proof and I will make a better idiot


Offline rejetto

  • Administrator
  • Tireless poster
  • *****
    • Posts: 13510
    • View Profile
select an account , drag it on the access box , realase it and select another account :D

i found no way to fix this. :(
i just changed the control, from listview to listbox.